Re: [PATCH] testsuite: Update Wconversion testcase check type.

[Palmer Dabbelt <palmer@dabbelt.com>]

On Wed, 11 May 2022 19:37:21 PDT (-0700), jiawei@iscas.ac.cn wrote:
>    Thank you, it hasn't commited into the trunk yet.

Should be now.
>
>    ISCAS
>
>    å¨ Palmer Dabbelt <palmer@dabbelt.com>ï¼2022å¹´5æ11æ¥ ä¸å5:59åéï¼
>
>      On Thu, 05 May 2022 11:45:50 PDT (-0700), [1]gcc-patches@gcc.gnu.org
>      wrote:
>      > On Thu, May 05, 2022 at 06:33:20PM +0800, jiawei wrote:
>      >> Some compiler target like arm-linux\riscv\power\s390x\xtensa-gcc
>      handle
>      >> char as unsigned char, then there are no warnings occur and got
>      FAIL cases.
>      >> Just change the type char into explicit signed char to keep the
>      feature
>      >> consistency.
>      >>
>      >> gcc/testsuite/ChangeLog:
>      >>
>      >>Â Â Â Â Â Â Â Â  * c-c++-common/Wconversion-1.c: Update type.
>      >
>      > Ok, and sorry for introducing this problem!
>      So this is OK for trunk?  Happy to commit it if you'd like, just
>      wanted
>      to make sure as I'm not seeing it on trunk.
>      >> ---
>      >>Â  gcc/testsuite/c-c++-common/Wconversion-1.c | 2 +-
>      >>Â  1 file changed, 1 insertion(+), 1 deletion(-)
>      >>
>      >> diff --git a/gcc/testsuite/c-c++-common/Wconversion-1.c
>      b/gcc/testsuite/c-c++-common/Wconversion-1.c
>      >> index ed65918c70f..7053f6b5dbb 100644
>      >> --- a/gcc/testsuite/c-c++-common/Wconversion-1.c
>      >> +++ b/gcc/testsuite/c-c++-common/Wconversion-1.c
>      >> @@ -10,5 +10,5 @@ void g()
>      >>Â Â Â  signed char sc = 300; /* { dg-warning "conversion from
>      .int. to .signed char. changes value from .300. to .44." } */
>      >>Â Â Â  unsigned char uc = 300; /* { dg-warning "conversion from
>      .int. to .unsigned char. changes value from .300. to .44." } */
>      >>Â Â Â  unsigned char uc2 = 300u; /* { dg-warning "conversion from
>      .unsigned int. to .unsigned char. changes value from .300. to .44."
>      } */
>      >> -Â  char c2 = (double)1.0 + 200; /* { dg-warning "overflow in
>      conversion from .double. to .char. changes value from .2.01e\\+2. to
>      .127." } */
>      >> +Â  signed char c2 = (double)1.0 + 200; /* { dg-warning "overflow
>      in conversion from .double. to .signed char. changes value from
>      .2.01e\\+2. to .127." } */
>      >>Â  }
>      >> --
>      >> 2.25.1
>      >>
>      >
>      > Marek
>
> References
>
>    1. mailto:gcc-patches@gcc.gnu.org