From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 1D4163858D1E for ; Tue, 18 Apr 2023 20:01:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D4163858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x102c.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso214306pjc.1 for ; Tue, 18 Apr 2023 13:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1681848071; x=1684440071; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=ru/E7QL4j0ImgqBS2M9kdBmCjPdkv7EKox2m6D7JjPA=; b=ZuzWPr5901RxQQnAJgZ5Tok6k9PCOSC7wF3IfhMqxFptRhgi1CQWI0TIXqM7yZsrfu Kj86KMuBsWyLuhvI55dwT+oWz1pjy6SA2PretHbHMGkX1Hq8Nc6WkU8AmCFD+XSKKQf0 kDFHSmIpgHVSNCvYlWrgpFsnyKQW8zl9NkaBfKY6QaQ9uMZctktqgxt7xLOTkbAx1WT1 j11LYV0CvEG2u4gjuuWL+gmjJtLQy8xPRDmMcQfh6vPSKLaYpDDFkMHH+/fDdTwH8FGp AZX1AsYtuVjp6prDwshyx7NeL3sHUsM8vqwFXTzk867GAYm+zCwdGr4xDLFDRWfqBP5X 2uqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681848071; x=1684440071; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ru/E7QL4j0ImgqBS2M9kdBmCjPdkv7EKox2m6D7JjPA=; b=eqQK60o43ia75qHYpUq5uhlDeAgg0bsXdvvxbqObzqEVrl2kb25wPrYGiM7hJDDSsU 1MCSfKNAWAP0qKU49lWkxo5d+GWjwTmJ3jZ4Jia2B92PMrU4DguP/H+XG4/u5Ht6zSnU AYOwar3EYLwglpU7DPfD/clzLyRVF1LEprL7RFqi+ys5ZFzYZ1tusiY4njmSFmE/CzW6 5A24YvRKNf3tCshrcG1CuYBH9hzy0fsGaRq8bRKoc3Y1pOvv24PKliYCZlLsxq4tSPto R+faFI7r6SBis3TeLopukWC6GjkyzapvDU/0PtYDNoi7grYAD96pdRhjNQZGsB7E865c NNMQ== X-Gm-Message-State: AAQBX9dL0Gl5gYCulHvi2DfK/b6L1jN6zv4UkVIkKYrpWw8uD2Ryy1B3 fnf+fVPRXCS1i4VIHDjj73IlCN8kM1mLUs5aD+Y= X-Google-Smtp-Source: AKy350bjBc7mCellobO6hE+ZlR0+fuGylXGP/aKVIqPvLdgnHpxOHM3ZBWiN2sRqAmhTJOCCVOdzsg== X-Received: by 2002:a05:6a20:12d2:b0:c6:c0c1:b1fe with SMTP id v18-20020a056a2012d200b000c6c0c1b1femr785539pzg.57.1681848070694; Tue, 18 Apr 2023 13:01:10 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id v6-20020a63f846000000b0050a0227a4bcsm9102128pgj.57.2023.04.18.13.01.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 13:01:09 -0700 (PDT) Date: Tue, 18 Apr 2023 13:01:09 -0700 (PDT) X-Google-Original-Date: Tue, 18 Apr 2023 13:00:58 PDT (-0700) Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V In-Reply-To: CC: gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: gcc-patches@gcc.gnu.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 18 Apr 2023 08:44:24 PDT (-0700), gcc-patches@gcc.gnu.org wrote: >> Yep, if I drop the non-canonicial strings via >> >> diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/riscv/multilib-generator >> index 58b7198b243..a63a4d69c18 100755 >> --- a/gcc/config/riscv/multilib-generator >> +++ b/gcc/config/riscv/multilib-generator >> @@ -174,7 +174,7 @@ for cmodel in cmodels: >> ext_combs = expand_combination(ext) >> alts = sum([[x] + [x + y for y in ext_combs] for x in [arch] + extra], []) >> alts = filter(lambda x: len(x) != 0, alts) >> - alts = alts + list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) >> + alts = list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) >> >> # Drop duplicated entry. >> alts = unique(alts) >> >> then I can't link `-march=rv32imafdcv`, I need >> `-march=rv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zvl64b`. That's >> kind of a headache for users to type in. > > Yes, that's a headache for users, but arch string canonicalization is > hiddened at the process, > so the user could still just use rv32imafdcv at compile time and > multi-lib config. > > And the driver and multilib-generator (with arch_canonicalize) script > will handle those headache in the background. Sorry, I'm not exactly sure what you're trying to say. I just rebuilt GCC with this patch (and t-linux-multilib regenerated from it), it's not resolving multlibs for the short names.