From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id A219538376C4 for ; Wed, 25 May 2022 21:32:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A219538376C4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pf1-x42b.google.com with SMTP id x143so40375pfc.11 for ; Wed, 25 May 2022 14:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=HzuSodMQc6QJf+Rmtt4ZMNPayK30UKHQBPoXTFjjpNE=; b=f9B5XeOdljkrcCXYes6cW4wK+t0N7gjUKjSipMF9o5Zw1znkfFOYObZNlShAZPp/ax O+qS+IFptkkS5EE0soSU1+mLz/ROiM+m9tDxEZAvC/bKvRqOgSeNIgxjahFYkacyNVl3 qB61+mZ1vY3kv2wWNGh108NqLvMrF9ThhHK0T/ISniB2MuDw0ieth4RtefmPR4s8875/ u/NZjYl3AC4S6ExBnZS1TlFpN1OWIKsPIwOx34nOJpELnfm5Zf/EtHw5ZtYoFce6kfKd XxQBbKW8pWA4L6wzH4YAOB9vfbbkwQ+fRCDbpv2enaZ4p5vzUyqBoJ1en1NnodBtmCzp hqmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=HzuSodMQc6QJf+Rmtt4ZMNPayK30UKHQBPoXTFjjpNE=; b=zxf0JJG9yE86NXqkNMEnONQGS8wEcPvC1Xtz3tt0HG0bsRxqhCzcj+jgDV6Hh2WXs/ a1mDrUOtDBhy7tQ7eLWjclcrM4vOzW8VsqaxYMKe/NqC/JIV9qmiKsP6TM73Oo87KxKk BZj5rU54i0zH7X9nyNqXx3r+4hZ8P9ikmR1HzXYnVnEkq1r5x62UMIba5Ej7DDmUGJF2 yGIFPQUFz+vneTdYsT79DvgIzSZoa8vGBPMGzc6OQYXKZTg7ETxqhHZ1VbuZw+NO3ZSS gGZyEqiYsUMmp6xDlyrrgCGgCcP7meElb9B46j++M6sseATTMZ3wvoOzODBrqTdQlbiz vGpg== X-Gm-Message-State: AOAM531OkpMB1knEovbq8u8ZqWGiq9Ah5XD4JKBWFKn9ck/3qvKrcU20 bXubel4tbjCrK++goscyeHKlBg== X-Google-Smtp-Source: ABdhPJwAIIMH98uglAS+qjHi8HN9NyaZZbLY1mvoT7S6J2xSHsqVn+HJagmyD75DPpd5B6eQ/H5rEQ== X-Received: by 2002:a63:520d:0:b0:3fa:52e2:1a1f with SMTP id g13-20020a63520d000000b003fa52e21a1fmr14540741pgb.546.1653514373099; Wed, 25 May 2022 14:32:53 -0700 (PDT) Received: from localhost ([12.3.194.138]) by smtp.gmail.com with ESMTPSA id g3-20020a170902d5c300b0015e8d4eb2b9sm9830229plh.259.2022.05.25.14.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 14:32:52 -0700 (PDT) Date: Wed, 25 May 2022 14:32:52 -0700 (PDT) X-Google-Original-Date: Wed, 25 May 2022 14:32:48 PDT (-0700) Subject: Re: [PATCH] RISC-V: Don't unconditionally add m, a, f, d in arch-canonicalize In-Reply-To: CC: simon.cook@embecosm.com, gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: gcc-patches@gcc.gnu.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 21:32:56 -0000 On Wed, 25 May 2022 07:00:11 PDT (-0700), gcc-patches@gcc.gnu.org wrote: > Committed, Thanks for fixing my stupid bug :P IMO this is a good candidate for a backport. > On Wed, May 25, 2022 at 9:26 PM Simon Cook wrote: >> >> This solves an issue where rv32i, etc. are canonicalized to rv32imafd >> since the g->i addition of 'm', 'a', 'f', 'd' is not actually gated by >> whether the input was rv32g/rv64g. >> >> gcc/ChangeLog: >> >> * config/riscv/arch-canonicalize: Only add mafd extension if >> base was rv32/rv64g. >> --- >> gcc/config/riscv/arch-canonicalize | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/config/riscv/arch-canonicalize >> b/gcc/config/riscv/arch-canonicalize >> index 71b2232b29e..fd7651ac491 100755 >> --- a/gcc/config/riscv/arch-canonicalize >> +++ b/gcc/config/riscv/arch-canonicalize >> @@ -73,8 +73,8 @@ def arch_canonicalize(arch, isa_spec): >> std_exts = [] >> if arch[:5] in ['rv32e', 'rv32i', 'rv32g', 'rv64i', 'rv64g']: >> new_arch = arch[:5].replace("g", "i") >> - std_exts = ['m', 'a', 'f', 'd'] >> if arch[:5] in ['rv32g', 'rv64g']: >> + std_exts = ['m', 'a', 'f', 'd'] >> if not is_isa_spec_2p2: >> extra_long_ext = ['zicsr', 'zifencei'] >> else: >> -- >> 2.32.1