From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 5AF00385840E for ; Mon, 31 Oct 2022 22:30:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AF00385840E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pg1-x535.google.com with SMTP id b5so11899164pgb.6 for ; Mon, 31 Oct 2022 15:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=7TLN2RO9NWff9tEXVFVT8dbldd02QxqoYLD3EbDBUlk=; b=Eqw9xagdIs6UJYwA8+dj97U6+OfW1bTeqFSvb7q3hiL/5AlY8wPW9G7zWrpeBnILEz lrr6p2cPGZF8NtC49pMkgRv5PRRSJIVbyIQnqmxn9ZtE8UYoXzZ/FEW6svYstEL/VxjI BAV8jrm4r9oaTgfewrCHB8ON5L4reYJFX9bWAlFPMQIt5LGgiwheuLz5vzSenOJxNv1I TmHUG3176/VxAtUKz+srf3JPEcxJLYnBUGee06JihXr/j6iTrRaNdA1tumM+5vzipQdZ Olplb2zN78WU4nzbf+4acWoFka6poEkoIoGlhqWm4hDupqhjpF2Sh8R+DhToaGVV2AJv 7rKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7TLN2RO9NWff9tEXVFVT8dbldd02QxqoYLD3EbDBUlk=; b=M3uSs2m+kUMd64px0LSzj4vz2sSrqKYDRx1ubn/wA3VZ0xj3DZC8Hp24IDkL23/1eA Af7xro+Ywo2XJLWIYTaWvShwsK/WheffFKptUptn4mEw6WNW4IW/CM1uWozWH9JCT1fl uArj4RO5jemw3BCegc9iytf6DnBBso+Sz1DwQZXylnYinqg6C60B2EOoHQhMKideTi7I Ujv7ekULH1lX1hmiPI0i68ND6ixgUZuIct+eKZTFjDZdGDM300rGN2gwrx616tk9UwsR Cc4P385L55EPc1KKpQQ7I/Rc4hXl6pW9hPxiz2kgD8T3trVu05hUuaWG/3UfixGZsdj8 AO1g== X-Gm-Message-State: ACrzQf2VpHQ7NdukaX8VDNqb/Zrmuc5eP0W+e4Tcvs1k6ElhIgWga1az feZitA/8PsGAtZCKGMYOdPJMtg== X-Google-Smtp-Source: AMsMyM648445TISyads9QnFpoARn7azjnj/9XoBJy+F7o81AvCgQwegYHQOV2XGYL4jC1pzkn79zqA== X-Received: by 2002:a63:d218:0:b0:46e:bcc2:1669 with SMTP id a24-20020a63d218000000b0046ebcc21669mr19255pgg.353.1667255449152; Mon, 31 Oct 2022 15:30:49 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id b29-20020a62a11d000000b0056c6c63fda6sm5128095pff.3.2022.10.31.15.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 15:30:48 -0700 (PDT) Date: Mon, 31 Oct 2022 15:30:48 -0700 (PDT) X-Google-Original-Date: Mon, 31 Oct 2022 15:30:50 PDT (-0700) Subject: Re: [PATCH] RISC-V: Fix RVV testcases. In-Reply-To: <87e80ca7-2d66-09b1-26e3-fe64c6553b28@gmail.com> CC: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org, schwab@linux-m68k.org, Kito Cheng From: Palmer Dabbelt To: gcc-patches@gcc.gnu.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 31 Oct 2022 15:00:49 PDT (-0700), gcc-patches@gcc.gnu.org wrote: > > On 10/30/22 19:40, juzhe.zhong@rivai.ai wrote: >> From: Ju-Zhe Zhong >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/riscv/rvv/base/abi-2.c: Change ilp32d to ilp32. >> * gcc.target/riscv/rvv/base/abi-3.c: Ditto. >> * gcc.target/riscv/rvv/base/abi-4.c: Ditto. >> * gcc.target/riscv/rvv/base/abi-5.c: Ditto. >> * gcc.target/riscv/rvv/base/abi-6.c: Ditto. >> * gcc.target/riscv/rvv/base/abi-7.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-1.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-10.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-11.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-12.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-13.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-2.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-3.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-4.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-5.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-6.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-7.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-8.c: Ditto. >> * gcc.target/riscv/rvv/base/mov-9.c: Ditto. >> * gcc.target/riscv/rvv/base/pragma-1.c: Ditto. >> * gcc.target/riscv/rvv/base/user-1.c: Ditto. >> * gcc.target/riscv/rvv/base/user-2.c: Ditto. >> * gcc.target/riscv/rvv/base/user-3.c: Ditto. >> * gcc.target/riscv/rvv/base/user-4.c: Ditto. >> * gcc.target/riscv/rvv/base/user-5.c: Ditto. >> * gcc.target/riscv/rvv/base/user-6.c: Ditto. >> * gcc.target/riscv/rvv/base/vsetvl-1.c: Ditto. > > I'm pretty new to the RISC-V world, but don't some of the cases > (particularly the abi-* tests) verify that the ABI specification does > not override the arch specification WRT availability of types? I think that depends on what the ABI specification says here, as it could really go many ways. Most of the RISC-V targets just use -mabi to control how arguments end up passed in functions, not the availability of types. I can't find the ABI spec for these, though, so I'm not entirely sure how they're supposed to work... That said, I'm not sure why we need any of these -mabi changes? Just from spot checking some of the examples it doesn't look like there should be any functional difference between ilp32 and ilp32d here: -march is always specified so ilp32d looks valid. If this is just to fix the "fails on targets without ilp32d" [1], then IMO it's not really a fix: we're essentially just changing that to "fails on targets without ilp32", we either need some sort of automatic march/mabi setting or a dependency on the availiable multilibs. Some of these can probably avoid linking, but we'll have execution tests at some point. 1: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604644.html