public inbox for
 help / color / mirror / Atom feed
From: Palmer Dabbelt <>
Subject: Re: [PATCH] Fix the build of record_edge_info()
Date: Fri, 30 Sep 2022 18:27:13 -0700 (PDT)	[thread overview]
Message-ID: <mhng-6a1f42bc-e673-4b47-8a96-64329b9b51df@palmer-ri-x1c9> (raw)
In-Reply-To: <>

On Fri, 30 Sep 2022 18:01:00 PDT (-0700), wrote:
> On 9/30/22 18:57, Palmer Dabbelt wrote:
>> As of 1214196da79 ("More gimple const/copy propagation opportunities"),
>> I'm getting some build failures during bootstrap
>>      ../../gcc/ In function ‘void record_edge_info(basic_block)’:
>>      ../../gcc/ error: ‘dst’ was not declared in this scope; did you mean ‘dse’?
>>        689 |                       if (dst == PHI_ARG_DEF (phi, !alternative))
>>            |                           ^~~
>>            |                           dse
>>      In file included from ../../gcc/gimple-ssa.h:24,
>>                       from ../../gcc/ssa.h:27,
>>                       from ../../gcc/
>>      ../../gcc/ error: ‘phi’ was not declared in this scope; did you mean ‘gphi’?
>>        689 |                       if (dst == PHI_ARG_DEF (phi, !alternative))
>>            |                                               ^~~
>>      ../../gcc/tree-ssa-operands.h:82:54: note: in definition of macro ‘PHI_ARG_DEF’
>>         82 | #define PHI_ARG_DEF(PHI, I)     gimple_phi_arg_def ((PHI), (I))
>>            |
>> I've never looked at this stuff before so I've sort of just pattern
>> matched this, it at least fixes the build.  Happy to go try and
>> understand what's going on here, but I'm in the middle of a few things
>> so I figured it'd be better to just send it along in case anyone else is
>> running into the same issue -- it's more of a bug report than a fix,
>> though.
>> gcc/ChangeLog
>> 	* tree-ssa-dom.c (record_edge_info): Move the alternative check
>> 	below the phi definition.
>> ---
> You got it right, but it's already fixed on the trunk (I pushed the
> wrong version of the patch).

Thanks, I must have just had some unlucky timing ;)

      reply	other threads:[~2022-10-01  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  0:57 Palmer Dabbelt
2022-10-01  1:01 ` Jeff Law
2022-10-01  1:27   ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-6a1f42bc-e673-4b47-8a96-64329b9b51df@palmer-ri-x1c9 \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).