From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id F21C13858C56 for ; Wed, 31 Aug 2022 14:57:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F21C13858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x1035.google.com with SMTP id fa2so6688820pjb.2 for ; Wed, 31 Aug 2022 07:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date; bh=oM9wONAvlIJF5mdqU+a1eMpSyCHTq8cOHwHduSPBxCU=; b=llQfDNk1BpV3ag+5xc6bh7sNoJKY2d1ZyHEUuWjb1jTV3hMjxYvBOhcb1NyfvicSPV AL7vNPPPf6d0QdU4D0Q4p49+5Xtfs9yaZV18tytxZCq90MUDsE4bZIMgRRBrhsrpCBLy hIbeZL/Y4tXRBCon5h5xIVG3oheqeiieSVFbgSCE0LHMpeZ4J2EYkxrW7GHBBHiGnOS5 R9B4C8wiRbdLYCjSbY5we69z1ty3vwI8dQO6NuKOjtBef8O5yh8TYk65RMW0udpVB/dc 6+fVQu69ntr0SUkrycuWLCtvqwJIs4g9ITRd5MZf0NVe1LLo24r6hHj0IaRc0q3rh0nw wEYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date; bh=oM9wONAvlIJF5mdqU+a1eMpSyCHTq8cOHwHduSPBxCU=; b=Ow0p0T5tXoa5LoMyE5k1BXMwUbcdTxJ6eIahjORaWnEPwGei6JLviEOS4g3OMJdSEi S+e4byWnWyYTsgZWg0hAPeIJQapBoK9qhZPzkDOJvlcj09uebfeXr3O8Ytoyvj9c/Bfd 3xHB60+ABcXTLJoy3TZR1XdfeHvDDm0OF5Dzm2R/KMlEQw5U/FWJINJlu1XyJ5RiFA09 Dh1SxBfW8+qstDgB4+DJJCDETx2E1Iz0qFStQU3yUmkwdYr+FFjfdxhOwssiBcesmUIE sngQgP+cgS1iaoCPYWjCR5Jr34xwYpoJUDLT1Zz8gwLmjWpN0dCNzpZQCCT8HKTI8Gi/ gyRw== X-Gm-Message-State: ACgBeo12fUj+SsOpeqMxOHa6GVQ1S2ed74T1IcB2I0YZZtcLGyEmYF9x yFBfv/ktUJu6xCqzU4dgt4xWC5Z1S6FkyQ== X-Google-Smtp-Source: AA6agR6BZmRN7aLAf0+6xxmkKC7tKR1mPkq+lN6Ki7WFhkuOQzV8zBcLGywgfOgSqFQV4+SoMhU9yw== X-Received: by 2002:a17:902:b697:b0:172:65f9:d681 with SMTP id c23-20020a170902b69700b0017265f9d681mr25753830pls.137.1661957859749; Wed, 31 Aug 2022 07:57:39 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id p12-20020a635b0c000000b0042a713dd68csm3461397pgb.53.2022.08.31.07.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 07:57:39 -0700 (PDT) Date: Wed, 31 Aug 2022 07:57:39 -0700 (PDT) X-Google-Original-Date: Wed, 31 Aug 2022 07:57:35 PDT (-0700) Subject: Re: [PATCH 2/2] RISC-V: remove CM_PIC as it doesn't do much In-Reply-To: <20220830174830.224541-3-vineetg@rivosinc.com> CC: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu, collison@rivosinc.com, gnu-toolchain@rivosinc.com, Vineet Gupta From: Palmer Dabbelt To: Vineet Gupta Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Aug 2022 10:48:30 PDT (-0700), Vineet Gupta wrote: > CM_PIC is no longer doing anything directly. Removing it might > potentially affect USE_LOAD_ADDRESS_MACRO() but seems unlikely. At least in the short term, there's kind of a mess here that needs to get sorted out but just removing CM_PIC doesn't really get us there. > Signed-off-by: Vineet Gupta > --- > gcc/config/riscv/riscv-c.cc | 4 ---- > gcc/config/riscv/riscv-opts.h | 3 +-- > gcc/config/riscv/riscv.cc | 2 +- > 3 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > index bba72cf77a82..7064fcf142fe 100644 > --- a/gcc/config/riscv/riscv-c.cc > +++ b/gcc/config/riscv/riscv-c.cc > @@ -92,13 +92,9 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > builtin_define ("__riscv_cmodel_medlow"); > break; > > - case CM_PIC: > - /* FALLTHROUGH. */ > - > case CM_MEDANY: > builtin_define ("__riscv_cmodel_medany"); > break; > - > } > > if (TARGET_MIN_VLEN != 0) > diff --git a/gcc/config/riscv/riscv-opts.h b/gcc/config/riscv/riscv-opts.h > index 85e869e62e3a..ce3237beca7a 100644 > --- a/gcc/config/riscv/riscv-opts.h > +++ b/gcc/config/riscv/riscv-opts.h > @@ -34,8 +34,7 @@ extern enum riscv_abi_type riscv_abi; > > enum riscv_code_model { > CM_MEDLOW, > - CM_MEDANY, > - CM_PIC > + CM_MEDANY > }; > extern enum riscv_code_model riscv_cmodel; > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index 7c120eaa8e33..a239fe43047c 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -5162,7 +5162,7 @@ riscv_option_override (void) > init_machine_status = &riscv_init_machine_status; > > if (flag_pic) > - riscv_cmodel = CM_PIC; > + riscv_cmodel = CM_MEDANY; > > /* We get better code with explicit relocs for CM_MEDLOW, but > worse code for the others (for now). Pick the best default. */ I'm fine either way on this one: having CM_PIC gone makes it a bit more likely to confuse CM_MEDANY with PIC, but flag_pic is overriding riscv_cmodel anyway so this isn't really used and deleting code is always a plus.