From: Palmer Dabbelt <palmer@dabbelt.com>
To: kito.cheng@sifive.com
Cc: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@gmail.com>,
Jim Wilson <jimw@sifive.com>,
i@maskray.me, kito.cheng@sifive.com
Subject: Re: [PATCH v2] docs: Add 'S' to Machine Constraints for RISC-V
Date: Thu, 15 Jul 2021 08:25:36 -0700 (PDT) [thread overview]
Message-ID: <mhng-7ab02e7a-c7e6-4385-87cc-155acfb996e6@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20210712042913.93981-1-kito.cheng@sifive.com>
On Sun, 11 Jul 2021 21:29:13 PDT (-0700), kito.cheng@sifive.com wrote:
> It was undocument before, but it might used in linux kernel for resolve
> code model issue, so LLVM community suggest we should document that,
> so that make it become supported/documented/non-internal machine constraints.
>
> gcc/ChangeLog:
>
> PR target/101275
> * config/riscv/constraints.md ("S"): Update description and remove
> @internal.
> * doc/md.texi (Machine Constraints): Document the 'S' constraints
> for RISC-V.
> ---
> gcc/config/riscv/constraints.md | 3 +--
> gcc/doc/md.texi | 3 +++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config/riscv/constraints.md b/gcc/config/riscv/constraints.md
> index 8c15c6c0486..c87d5b796a5 100644
> --- a/gcc/config/riscv/constraints.md
> +++ b/gcc/config/riscv/constraints.md
> @@ -67,8 +67,7 @@ (define_memory_constraint "A"
> (match_test "GET_CODE(XEXP(op,0)) == REG")))
>
> (define_constraint "S"
> - "@internal
> - A constant call address."
> + "A constraint that matches an absolute symbolic address."
> (match_operand 0 "absolute_symbolic_operand"))
>
> (define_constraint "U"
> diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
> index 00caf3844cc..2d120da96cf 100644
> --- a/gcc/doc/md.texi
> +++ b/gcc/doc/md.texi
> @@ -3536,6 +3536,9 @@ A 5-bit unsigned immediate for CSR access instructions.
> @item A
> An address that is held in a general-purpose register.
>
> +@item S
> +A constraint that matches an absolute symbolic address.
> +
> @end table
>
> @item RX---@file{config/rx/constraints.md}
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
prev parent reply other threads:[~2021-07-15 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 4:29 Kito Cheng
2021-07-12 4:47 ` Fangrui Song
2021-07-13 6:11 ` Kito Cheng
2021-07-15 15:25 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-7ab02e7a-c7e6-4385-87cc-155acfb996e6@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@maskray.me \
--cc=jimw@sifive.com \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).