From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 6610E3988425 for ; Thu, 15 Jul 2021 15:25:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6610E3988425 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pf1-x42a.google.com with SMTP id p36so5647756pfw.11 for ; Thu, 15 Jul 2021 08:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=2MlllMAxKLC16cRiXRyoxn6TvclpX8JFOPjHD7H5im8=; b=oQKCEkBl0Rg3WD6sTqgSkptId2oaSk6U/UecNO9Vl8CVLVeFGzppNFoHCopTLq+vX9 Ny1skf/cJzi50utqyS3MtL4rE7MaNFBAOAnjsiIVM+pAmOHvN4NFZjn8AcrvdIHddml5 7P8sYYVW9ZrCMZeowZxVGzH8MAoYTmJ3tbSjapYGf0S0yX2TR9KyH6eWrbJX2yu+P0hd Pp0RmKLTnJJDOBEXf8RXQ+eYiEM5hAjEX9pIIxM9l+2CUw0Ylzp+xoDJVkiJBPCiwMjF 1nj4Nh5ZHTd3G2w2vazyedAoOb9XmVDGmv3yhZYjJsQW87JdCRGc9/HaK0kj/gmLrftM fj2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=2MlllMAxKLC16cRiXRyoxn6TvclpX8JFOPjHD7H5im8=; b=EwVx8lmvEDkui+iDMeO3n8DKztPCxUAQWP70uQ+xft7KWwrPfoFLPuVhviLPoennbT ldl/q/6CFL+MTVF61rBzrf4vCjmGmrJ4jsboFBD3LZF2VjxDKbWZ3YAWHY923GTVqmoe ofyprQ0G0N9MzWs9o+bnmRg8BH2gvYustKpzzv0SWRX4z2BxU+1YgYcQ0QNogPONp90o Y3f6StJ1d9pPQNi/+MHBKQg3A8fMBEMOPdUZXrtM3Of3ifHZidEZZ2GNOXF5HY6gnRKi Jopa8vmX6pJdX18VbA5lRVtj5esWhz7eO1EAL225x/TpYzP6LJrtOqRgoP/+kErpCEYj HkiA== X-Gm-Message-State: AOAM530PvshTXLOpWQMbnYrRqXcpwrFo95ypEmJbudQ/0CQLZSRQUi+Y mP6UySsJQHDoJ+7pCrbFYla4dYN/AI308A== X-Google-Smtp-Source: ABdhPJyGaDR7237TbhyhoLEU1CSRRlmETdcPxN4IGFnCFNZrQR49Vhyb0yO7oFVMHburbjYIo0OIpA== X-Received: by 2002:a65:6494:: with SMTP id e20mr5236368pgv.101.1626362737201; Thu, 15 Jul 2021 08:25:37 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id y13sm7307419pgp.16.2021.07.15.08.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 08:25:36 -0700 (PDT) Date: Thu, 15 Jul 2021 08:25:36 -0700 (PDT) X-Google-Original-Date: Thu, 15 Jul 2021 08:25:32 PDT (-0700) Subject: Re: [PATCH v2] docs: Add 'S' to Machine Constraints for RISC-V In-Reply-To: <20210712042913.93981-1-kito.cheng@sifive.com> CC: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , i@maskray.me, kito.cheng@sifive.com From: Palmer Dabbelt To: kito.cheng@sifive.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 15:25:39 -0000 On Sun, 11 Jul 2021 21:29:13 PDT (-0700), kito.cheng@sifive.com wrote: > It was undocument before, but it might used in linux kernel for resolve > code model issue, so LLVM community suggest we should document that, > so that make it become supported/documented/non-internal machine constraints. > > gcc/ChangeLog: > > PR target/101275 > * config/riscv/constraints.md ("S"): Update description and remove > @internal. > * doc/md.texi (Machine Constraints): Document the 'S' constraints > for RISC-V. > --- > gcc/config/riscv/constraints.md | 3 +-- > gcc/doc/md.texi | 3 +++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/riscv/constraints.md b/gcc/config/riscv/constraints.md > index 8c15c6c0486..c87d5b796a5 100644 > --- a/gcc/config/riscv/constraints.md > +++ b/gcc/config/riscv/constraints.md > @@ -67,8 +67,7 @@ (define_memory_constraint "A" > (match_test "GET_CODE(XEXP(op,0)) == REG"))) > > (define_constraint "S" > - "@internal > - A constant call address." > + "A constraint that matches an absolute symbolic address." > (match_operand 0 "absolute_symbolic_operand")) > > (define_constraint "U" > diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi > index 00caf3844cc..2d120da96cf 100644 > --- a/gcc/doc/md.texi > +++ b/gcc/doc/md.texi > @@ -3536,6 +3536,9 @@ A 5-bit unsigned immediate for CSR access instructions. > @item A > An address that is held in a general-purpose register. > > +@item S > +A constraint that matches an absolute symbolic address. > + > @end table > > @item RX---@file{config/rx/constraints.md} Reviewed-by: Palmer Dabbelt