From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 5A48A385DC3A for ; Fri, 13 May 2022 16:54:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A48A385DC3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62d.google.com with SMTP id d17so8540405plg.0 for ; Fri, 13 May 2022 09:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=OQSK8YF/HhXKh+uPEhXR9/ImzsUkKp9zEM5vsQlTeZg=; b=S4n/6P9jdeCLICIYviCkDfFq94ZaTunuKbzday5OMqnVnm6wxkad7m9v+rW2zDKVsi jueer86r8Vmx0SM9RuVO2d97cxfphTUJQ0gej3NZSauE8GWYGY602oVH3Syl/Pg4CT04 BtFZpJXm2PHU41cwuo7Rwlq9LjIyWYkes3jyksy9AeIJvnFoaUoOZBclchuz/LgAfHw6 UCEhfLZfQOhbGz9EHgbvDYi+aOlEuj3zRz07hsWxPOz6/IZ7/kL0lG7DyI03JaGwYsBC KPv1Yvr8vU632c0lCV2gh7MWSpcYrZs7xh+9CJ/aaD5o0sI9b2NV3Le8QM+zbzwZdAkA DCaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=OQSK8YF/HhXKh+uPEhXR9/ImzsUkKp9zEM5vsQlTeZg=; b=FFZHbIEID51o62pN3XqX1J/954fn+sPVzoBFOUmLzZghMq5xiGsEszLNXZqgXoTEDU CCf7GePJXdwq1/o0SuRj5y+ZDjrxVbO3M0ac4sSWTVNNIUwmOO2WNqqjoiiljcryXxf6 v56i29LSGRLpG12I480tpAbbi2kNAcbHq8V4NV1HVJ8spR3Gbr9AmYoAaZiyLIZQ95GJ VKPnzLiae1/ncDDQObiQ2JlRX21JRnFUrV4sqPqEmX5ehOx3OBCqFURdGQMSc7MtidtA 7e+6JTWabyYvMwPEtgfRDpSCk8blFbiqqiENkzODIjdUWoryR7jwSh3LgTxIaYRK+E0o BDZQ== X-Gm-Message-State: AOAM533FgLG6ZBogOZoJK8LVwHpPDET4T1O9AG+hpRqMTaxBBoAK4Pfc UddX4iJ935YPK6ieRq+DpWOO+/lJ+mo8aw== X-Google-Smtp-Source: ABdhPJw/qBHLymok0JVvijxtD7aAXi/0A1oEKZvXTpILqjjY3xXsF3nRfNLJXuaA4uggHGaNcDTmcg== X-Received: by 2002:a17:903:41ce:b0:15e:ae15:2910 with SMTP id u14-20020a17090341ce00b0015eae152910mr5792577ple.21.1652460839213; Fri, 13 May 2022 09:53:59 -0700 (PDT) Received: from localhost ([2607:fb91:792d:f71d:c212:e279:d579:e41c]) by smtp.gmail.com with ESMTPSA id z8-20020a630a48000000b003db4fa137fdsm1811954pgk.92.2022.05.13.09.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 09:53:58 -0700 (PDT) Date: Fri, 13 May 2022 09:53:58 -0700 (PDT) X-Google-Original-Date: Fri, 13 May 2022 09:53:55 PDT (-0700) Subject: Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V In-Reply-To: CC: gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: Kito Cheng Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 16:54:01 -0000 On Tue, 10 May 2022 18:31:37 PDT (-0700), Kito Cheng wrote: > LGTM, that's only added a new option for RISC-V and won't affect all > other targets, so I assume I can approve that. I always forget what the rules are, but someone recently reminded me and yes that's the case. I committed this. Thanks! > > On Wed, May 4, 2022 at 8:27 AM Palmer Dabbelt wrote: >> >> Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with >> -m32"), RISC-V needs to be told not to put symbols in the >> sdata/srodata/sbss sections. >> >> gcc/testsuite/ChangeLog >> >> * debug/btf/btf-datasec-1.c: Don't use small data on RISC-V. >> --- >> gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c >> index dbb236bbda1..77df88648c5 100644 >> --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c >> +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c >> @@ -12,6 +12,7 @@ >> /* { dg-do compile ) */ >> /* { dg-options "-O0 -gbtf -dA" } */ >> /* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */ >> +/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */ >> /* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */ >> >> /* Check for two DATASEC entries with vlen 3, and one with vlen 1. */ >> -- >> 2.34.1 >>