From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id C02243858D1E for ; Wed, 19 Apr 2023 00:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C02243858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-246fa478d45so2444150a91.3 for ; Tue, 18 Apr 2023 17:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1681865472; x=1684457472; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=XirffvHASD7+JP8ljJgpJyb2skFrFYv+VaIsUIhjDDk=; b=CS0DchzgDMJMi1eAZxLN7BVN9MNMJC90vW7KXkgHeP7XAQ/Ij4jeONm8OSE+bWh0T9 1ww3eOhWiYitptC+xRwI1eoCvHMLXqmds2bVU795tfO9Zzjn8eyP/q/kVNjxf9OZXM2k vFnOG4Nl5FW/NS6i+CF1qLKk39NMZu37Psr3OZBSQWfepnmYGq/dz6/MTL1beO5leI8e 1PBjoCmlmdWyRT3rTT6PpE5mbV994UeTDZHIiohtlTZv6A0ersW4lkgAY7HsexfM8gUz TeBmYCcqTT6HLU9Hru+xHQpgEMc4C115FUyNDqIW3PwKNrY7K1BQmgqKZOkeDhg/KSZi zOKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681865472; x=1684457472; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XirffvHASD7+JP8ljJgpJyb2skFrFYv+VaIsUIhjDDk=; b=SOAlBUTAL1kN/3kIykn1SA5+t/L6GxYe8t1a0rOOfbc4faJp6exNyWdphkIAni9CPz pTOEURWfbKfaKFAIzfwfX11LoFRESr/i2R+GYTmvhVy0XOQ4B3xCoNS65M+gdquKUjx9 /9/aFd2TdVQ3wIa0ErugZH+0Q48m7i8JER4Y+qYtc0AMLug0HgztFGJJwmD8gU96CJd9 Zlig5A5P3PfzO0IcqLPJHnjGEt2HLhn0cxr+Gv9QE920/TlsDSWJrV7hTDS3gRynTdVK m77tOxDGEar+VzhV1xDfCDthiRuN9Wdy5dOo5rhE/iL2t64mFRZM7or5kH3vu7zGByus G6qQ== X-Gm-Message-State: AAQBX9dI0y91Wh+i4XL6qTB4Y3XU8tgNhkb9N+rY5/UUTQgZNb0hJd9V lvn6OZyBPzBYDsSecCAzXZR7AdsCS9YrOGoXEHM= X-Google-Smtp-Source: AKy350am5oaYDVyYJidTcGDemybPYV/8+CzbUgNmBZKXSUqKcGdrakoHqSpAShhmY8MzfoyUjo3hFw== X-Received: by 2002:a17:90b:1c82:b0:23c:ffbf:859e with SMTP id oo2-20020a17090b1c8200b0023cffbf859emr1102438pjb.35.1681865472198; Tue, 18 Apr 2023 17:51:12 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id ji17-20020a170903325100b001a522cd8545sm10174653plb.130.2023.04.18.17.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 17:51:11 -0700 (PDT) Date: Tue, 18 Apr 2023 17:51:11 -0700 (PDT) X-Google-Original-Date: Tue, 18 Apr 2023 17:51:01 PDT (-0700) Subject: Re: [PATCH] RISC-V: Update multilib-generator to handle V In-Reply-To: CC: gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: Kito Cheng Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 18 Apr 2023 17:47:31 PDT (-0700), Kito Cheng wrote: > Do you mind shared gcc configure and the option you tried? Just riscv-gnu-toolchain with "--enbale-multilib --enable-linux". > On Wed, Apr 19, 2023 at 4:01 AM Palmer Dabbelt wrote: >> >> On Tue, 18 Apr 2023 08:44:24 PDT (-0700), gcc-patches@gcc.gnu.org wrote: >> >> Yep, if I drop the non-canonicial strings via >> >> >> >> diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/riscv/multilib-generator >> >> index 58b7198b243..a63a4d69c18 100755 >> >> --- a/gcc/config/riscv/multilib-generator >> >> +++ b/gcc/config/riscv/multilib-generator >> >> @@ -174,7 +174,7 @@ for cmodel in cmodels: >> >> ext_combs = expand_combination(ext) >> >> alts = sum([[x] + [x + y for y in ext_combs] for x in [arch] + extra], []) >> >> alts = filter(lambda x: len(x) != 0, alts) >> >> - alts = alts + list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) >> >> + alts = list(map(lambda a : arch_canonicalize(a, args.misa_spec), alts)) >> >> >> >> # Drop duplicated entry. >> >> alts = unique(alts) >> >> >> >> then I can't link `-march=rv32imafdcv`, I need >> >> `-march=rv32imacv_zicsr_zve32f_zve32x_zve64x_zvl128b_zvl32b_zvl64b`. That's >> >> kind of a headache for users to type in. >> > >> > Yes, that's a headache for users, but arch string canonicalization is >> > hiddened at the process, >> > so the user could still just use rv32imafdcv at compile time and >> > multi-lib config. >> > >> > And the driver and multilib-generator (with arch_canonicalize) script >> > will handle those headache in the background. >> >> Sorry, I'm not exactly sure what you're trying to say. I just rebuilt >> GCC with this patch (and t-linux-multilib regenerated from it), it's not >> resolving multlibs for the short names.