From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 317C13858D20 for ; Wed, 24 May 2023 23:13:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 317C13858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-64d2a87b9daso1144005b3a.0 for ; Wed, 24 May 2023 16:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1684970009; x=1687562009; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=Pu5G6EfGpfQidHo3sCvUKPHojsr3SlII2btm4X4FF0I=; b=0YWzv3nAm3pP+1o4vKFlrpp2VlDlL4MDhQriyV/AOf0JT8pr971Ui7maKwQXyUNQ65 9Lwj8KyhDOu3L72Wzqe+GHwE0QmiiX40BOkOrQ3y5Y6E/DXYqze4y/J1WF9KSooxm9IH 6USEYDDpZ/QfbRyosf/LCpbo6PVcV57DYadWyLFJPZhUJxtU3uajU602c/hhcygjkLvd URaBpniSLgIEtG3b5fqTHL3m1M3zAb9fS1hYl+84Mdr42DaHXhEJpDBZjb8D2CSbpGSF 7IFC4DdAr5/856NDu/6ja4Y1/UD/lBLkODpBvLgdNTZvY+3WUihtcr9CH8TFYpD1UKbE ysfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684970009; x=1687562009; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pu5G6EfGpfQidHo3sCvUKPHojsr3SlII2btm4X4FF0I=; b=NrO3zKl9lKSTEgm2ya6eFz8H43+ltF0nm/C6Ev/IpnQ41sY47anh4eE+yfazbmOIPf yvK+kQFshhiwJXO+6EaTO7yZ/RWdsIVchhS5vZYV8TE/rh85u6RDuJdtAhMQCOJ0gdXi Nhv6iaPQoVMNMuYTw4yieAxLHDq6SBzEuegFu3ZFLnYzMZOjppjgnz8nSVJUrMKjO7qw ++fABdiWfJRJMxvjTiLCxP+SJ346EPiBKYfhkocNr/OSdCy4o3t+G6zoFOcsspcL4Z2y EDjLIQCiXKtZ3esz+WkGni9Ny6YgzAlrDrhvOBKYPVkdBJP8rMeIq04Ocs4wCqcjj6ko PDcA== X-Gm-Message-State: AC+VfDxngsPwRHbS/5en0TAxWBTLZ9bVlN0q5Q++4CE1EXjcoUqJiqvV yyLLVEeuca76OBF7G7WMRFfGWQ== X-Google-Smtp-Source: ACHHUZ6DutJ5O+kxVj0sgOEhgAMKolAGWibDlqwkrXAtJFZZTAgeheT9TotLs37l82bex5HGSbeYTg== X-Received: by 2002:a05:6a21:3299:b0:101:4348:3e4e with SMTP id yt25-20020a056a21329900b0010143483e4emr22104679pzb.42.1684970009092; Wed, 24 May 2023 16:13:29 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id y8-20020a634b08000000b00520f4ecd71esm8216326pga.93.2023.05.24.16.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 16:13:28 -0700 (PDT) Date: Wed, 24 May 2023 16:13:28 -0700 (PDT) X-Google-Original-Date: Wed, 24 May 2023 16:13:03 PDT (-0700) Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp In-Reply-To: <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com> CC: thomas.schwinge@siemens.com, kito.cheng@sifive.com, gcc-patches@gcc.gnu.org, Kito Cheng , Patrick O'Neill , Jeff Law , macro@embecosm.com From: Palmer Dabbelt To: Vineet Gupta Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 24 May 2023 16:12:20 PDT (-0700), Vineet Gupta wrote: > > > On 5/24/23 15:13, Vineet Gupta wrote: >> >> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin >> -fno-fat-lto-objects  (test for excess errors) >> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin >> -fno-fat-lto-objects   scan-assembler-times mul\t 1 >> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin >> -fno-fat-lto-objects   scan-assembler-not div\t >> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin >> -fno-fat-lto-objects   scan-assembler-not rem\t >> testcase >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp >> completed in 60 seconds >> Running >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> ... >> ERROR: tcl error sourcing >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp. >> ERROR: tcl error code NONE >> ERROR: torture-init: torture_without_loops is not empty as expected >>     while executing >> "error "torture-init: torture_without_loops is not empty as expected"" >>     invoked from within >> "if [info exists torture_without_loops] { >>     error "torture-init: torture_without_loops is not empty as expected" >>     }" >>     (procedure "torture-init" line 4) >>     invoked from within >> "torture-init" >>     (file >> "/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" >> line 42) >>     invoked from within >> "source >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" >>     ("uplevel" body line 1) >>     invoked from within >> "uplevel #0 source >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" >>     invoked from within >> "catch "uplevel #0 source $test_file_name" msg" >> UNRESOLVED: testcase >> '/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp' >> aborted due to Tcl error >> testcase >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >> completed in 0 seconds >> Running >> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/rl78/rl78.exp >> ... >> ... >> > > Never mind. Looks like I found the issue - with just trial and error and > no idea of how this stuff works. > The torture-{init,finish} needs to be in riscv.exp not rvv.exp > Running full tests now. Thanks! > > -Vineet