From: Palmer Dabbelt <palmer@dabbelt.com>
To: ewlu@rivosinc.com
Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com, ewlu@rivosinc.com
Subject: Re: [PATCH] RISC-V: Fix rvv intrinsic pragma tests dejagnu selector
Date: Tue, 30 Jan 2024 09:51:08 -0800 (PST) [thread overview]
Message-ID: <mhng-c11d8c78-eecb-4607-9925-4d8d63c043c8@palmer-ri-x1c9a> (raw)
In-Reply-To: <20240129193812.1143289-1-ewlu@rivosinc.com>
On Mon, 29 Jan 2024 11:38:12 PST (-0800), ewlu@rivosinc.com wrote:
> Adding rvv related flags (i.e. --param=riscv-autovec-preference) to
> non vector targets bypassed the dejagnu skip test directive. Change the
> target selector to skip if rvv is enabled
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/rvv/base/abi-1.c: change selector
> * gcc.target/riscv/rvv/base/pragma-2.c: ditto
> * gcc.target/riscv/rvv/base/pragma-3.c: ditto
>
> Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
> ---
> gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c | 2 +-
> gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c | 2 +-
> gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c b/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c
> index 2eef9e1e1a8..a072bdd47bf 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile { target { ! riscv_xtheadvector } } } */
> -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */
> +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } } */
>
> void foo0 () {__rvv_bool64_t t;}
> void foo1 () {__rvv_bool32_t t;}
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c
> index fd2aa3066cd..fc1bb13c53d 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c
> @@ -1,4 +1,4 @@
> /* { dg-do compile } */
> -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */
> +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } } */
>
> #pragma riscv intrinsic "vector"
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c
> index 96a0e051a29..45580bb2faa 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c
> @@ -1,4 +1,4 @@
> /* { dg-do compile } */
> -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */
> +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } */
>
> #pragma riscv intrinsic "report-error" /* { dg-error {unknown '#pragma riscv intrinsic' option 'report-error'} } */
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
next prev parent reply other threads:[~2024-01-30 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 19:38 Edwin Lu
2024-01-30 17:51 ` Palmer Dabbelt [this message]
2024-02-08 17:59 ` [Committed] " Edwin Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-c11d8c78-eecb-4607-9925-4d8d63c043c8@palmer-ri-x1c9a \
--to=palmer@dabbelt.com \
--cc=ewlu@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).