From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 36C8D3858C5E for ; Tue, 30 Jan 2024 17:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36C8D3858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36C8D3858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706637073; cv=none; b=wPMqEBlaosxNmBKAJBb5NnHc3zvyw85WV89YjCfMA+zlWgCsGS+alnf4yzud5eYu/70E+lucYleMB+rs6FXoGQ+439GwXH2WotcsT3QMOr6wAeok+HuNUtliW6o791Kqx+fqp/q8kDwQPvTgFQJwc1GTMoBO43t9lJjHsczIFLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706637073; c=relaxed/simple; bh=9QmI2UZSBnfdS3mIBqdX9xYbQNXgAt284szDB9jzwv8=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=SELB0syru8SNrp1iFdKC6CDvFIiwLTDiRdFKYHEx9fMfvEBuEXA46wzc81XgGpsHNhVjIA3pzP/KZGo8RDqE2JPeS99dcl4zgzzAkoUkYL7pa64LKKcQusf8LcIZ2+TrN2MlsL7vZ3OW/79GnnCCD8BVycgZC8h8sLuWEfD3VJ4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5cf2d73a183so32034a12.1 for ; Tue, 30 Jan 2024 09:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1706637070; x=1707241870; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=/B3Slq9c70/gYAyTOUX602ywv+PqZ7kfO5Iq4AI/v6s=; b=fZt1lHZtL4V+2/iIlCqNsYOX3lGZaW8Fpqo4ZFsYhXosBBss1EOnV4W0I5Kg7kyDD8 quJCHa3nOfUuLDA4GNZPQokpVtPuObx4dz+vfTNTNBtk6j/0OoTTEDXjmGYJglzAMEcs mFGkZECYqh88EGn4y35oGCkCTu7q3QhMTZ31y/OiG4E3cUo/9F03Ca7IOZCsxOrB3roX m7+U6oVGuie7wz6TPCM7kj49J6gFTwGvnHYHVIFAux9Fe9WQI3XoJlDwu7e20LXQR7mf ujNkwW/6ppVoUeK4fH264/pplqcFLqy8nJbRwV0MzMX83oPF8ap1evRWhZL4/d81CDKg znnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706637070; x=1707241870; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/B3Slq9c70/gYAyTOUX602ywv+PqZ7kfO5Iq4AI/v6s=; b=NAHn24hKFvvEEnP/wBINyiwTus/5vhLTzfnbCLVS1EsILxBmgHXYUm5CJW+KxGI0I5 oO/wqYzEFHLwAQwYhdiA5rmLqApJ/jbpX/jlx9Fn2LxbSRHKCOG4q/pXP+m8sQ189N0u F7zBrUwR4T9so4w3KDuB+E8ACgjFN2+ynDDCYMF9mie473GybjEVL4Hq7YnhTDiEVkDK pqhNyp6SgTJKzPxdvMBh4Q7odT5q+iA6tofGljtnFV/sVCcHwBBurHBmKztpyzg0jUDP sMdzG4xKOSwti19SXiqrxIU3N/eKQ4surQrO4lDJXl/w3VYIIPXhI9bKSOiqUpGFFhwg uN9w== X-Gm-Message-State: AOJu0Yz7U3bcGobuTCibHz84t+YAVuZCT+OG3k+ok4CwxZ+ild5fChJ6 r493ggPAKpUicFZrRHy+9CICqfTEOdwQynX8cpzyUqxWv7swaWGaLjuaxN7s9X10R0wHpC5LJcZ g X-Google-Smtp-Source: AGHT+IHG85PFtRYC/a+84itF2Ug6nweUXbxwgI3A7DG7eQrg1Wel9XTMWYCrlxkxccRsa/O7tmCawA== X-Received: by 2002:a05:6a20:7906:b0:19c:51f2:3ff1 with SMTP id b6-20020a056a20790600b0019c51f23ff1mr1648331pzg.11.1706637069640; Tue, 30 Jan 2024 09:51:09 -0800 (PST) Received: from localhost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id m12-20020aa78a0c000000b006ddb1286b74sm8018112pfa.105.2024.01.30.09.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 09:51:08 -0800 (PST) Date: Tue, 30 Jan 2024 09:51:08 -0800 (PST) X-Google-Original-Date: Tue, 30 Jan 2024 09:51:05 PST (-0800) Subject: Re: [PATCH] RISC-V: Fix rvv intrinsic pragma tests dejagnu selector In-Reply-To: <20240129193812.1143289-1-ewlu@rivosinc.com> CC: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com, ewlu@rivosinc.com From: Palmer Dabbelt To: ewlu@rivosinc.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 29 Jan 2024 11:38:12 PST (-0800), ewlu@rivosinc.com wrote: > Adding rvv related flags (i.e. --param=riscv-autovec-preference) to > non vector targets bypassed the dejagnu skip test directive. Change the > target selector to skip if rvv is enabled > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/base/abi-1.c: change selector > * gcc.target/riscv/rvv/base/pragma-2.c: ditto > * gcc.target/riscv/rvv/base/pragma-3.c: ditto > > Signed-off-by: Edwin Lu > --- > gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c | 2 +- > gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c | 2 +- > gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c b/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c > index 2eef9e1e1a8..a072bdd47bf 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/abi-1.c > @@ -1,5 +1,5 @@ > /* { dg-do compile { target { ! riscv_xtheadvector } } } */ > -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */ > +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } } */ > > void foo0 () {__rvv_bool64_t t;} > void foo1 () {__rvv_bool32_t t;} > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c > index fd2aa3066cd..fc1bb13c53d 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-2.c > @@ -1,4 +1,4 @@ > /* { dg-do compile } */ > -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */ > +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } } */ > > #pragma riscv intrinsic "vector" > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c > index 96a0e051a29..45580bb2faa 100644 > --- a/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/pragma-3.c > @@ -1,4 +1,4 @@ > /* { dg-do compile } */ > -/* { dg-skip-if "test rvv intrinsic" { *-*-* } { "*" } { "-march=rv*v*" } } */ > +/* { dg-skip-if "test rvv intrinsic" { ! riscv_v } */ > > #pragma riscv intrinsic "report-error" /* { dg-error {unknown '#pragma riscv intrinsic' option 'report-error'} } */ Reviewed-by: Palmer Dabbelt