From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 5A3E23858D32 for ; Wed, 9 Nov 2022 04:53:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A3E23858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x432.google.com with SMTP id q9so15666382pfg.5 for ; Tue, 08 Nov 2022 20:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=H4gWrkhEawZgZDounC15p8uO3DXG6tXm/efNMocdqbM=; b=4OtbcFwHtNdAE++5MhpfOPDSsgzViT6u6PcU1zzdmHmi1+qAZUTpkUhQgY8ymlCMUV 5ko6GZ3GeE1Wt48JXbA16sqMyD8F6cJkzSvkqFS7zcOEwEskduvgp9rLXzKirK8DY9ju rCBbLcU91wb5hTZy9MqMdnk4Ohxi1JBJ2FWY023uR/HplBhdxhSHfdQIPQsVcff21PcD 2oiF9Ur4kx+nL22imO467JCYACOxaq1U2yEYgBlajJXoqJC8H64bPVqJTtGOaPmzoZQh Fme7wXNyS3oeopTVpCOrLidOrP6ONWqRtyxzliiPj5/Wyh5oowsh/X75u7QQsinLbsH3 nfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H4gWrkhEawZgZDounC15p8uO3DXG6tXm/efNMocdqbM=; b=q113teEtKAx6QdEdoV08KB9T0Li6d6S/8d/ydW1QeSrsuaX1YmkIqbfPcCvG7iru/+ FxpL8y0Fi8qqrOcsAsEVElNn17tgr4I6Flcd/UfVQt0hvy9oZDBAbRf3yDLthY7Pu/eA EyCjAwyMD1Et03ZEpjl4fLfiONRszLtvdyczX/ut2s6MpBE2dsBE9DdnSIHo0z/EWrxH IN97LKnlpQi77uDTuLHTEYabIfltmD1VTJnUn3O4moO7Qo2vyo0wpAhbeZnL+kIOSKSm bIiofabc1SUihQGrsCGRKRzZpSwn3c97g3/klWXH6GH7ETQvhEFXcu/0iauibPy2U7I8 +9rw== X-Gm-Message-State: ACrzQf045cIKyqLIUAOP9LgOSEDi71+MmrdzTVbZx6eoECRUbIAwkGf2 UH8/fl4dfOrfYc6DAyrtaov93Q== X-Google-Smtp-Source: AMsMyM7EoYibsgbf3/Q4k4/6Sd1Kp/8V/+lUuNK+7p9tPUqrVCIgt/G3WInmWJxDuMytinI48sYKiQ== X-Received: by 2002:a63:2a86:0:b0:46a:eaba:f1f3 with SMTP id q128-20020a632a86000000b0046aeabaf1f3mr50312182pgq.79.1667969588160; Tue, 08 Nov 2022 20:53:08 -0800 (PST) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id z3-20020a17090a6d0300b0020d45a155d9sm182291pjj.35.2022.11.08.20.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 20:53:07 -0800 (PST) Date: Tue, 08 Nov 2022 20:53:07 -0800 (PST) X-Google-Original-Date: Tue, 08 Nov 2022 20:53:04 PST (-0800) Subject: Re: [PATCH] RISC-V: costs: handle BSWAP In-Reply-To: CC: jeffreyalaw@gmail.com, philipp.tomsich@vrull.eu, gcc-patches@gcc.gnu.org, Kito Cheng , christoph.muellner@vrull.eu, Vineet Gupta , jlaw@ventanamicro.com From: Palmer Dabbelt To: pinskia@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 08 Nov 2022 20:43:20 PST (-0800), pinskia@gmail.com wrote: > On Tue, Nov 8, 2022 at 7:16 PM Palmer Dabbelt wrote: >> >> On Tue, 08 Nov 2022 18:57:26 PST (-0800), jeffreyalaw@gmail.com wrote: >> > >> > On 11/8/22 12:54, Philipp Tomsich wrote: >> >> The BSWAP operation is not handled in rtx_costs. Add it. >> >> >> >> With Zbb, BSWAP for XLEN is a single instruction; for smaller modes, >> >> it will expand into two. >> >> >> >> gcc/ChangeLog: >> >> >> >> * config/riscv/riscv.c (rtx_costs): Add BSWAP. >> > >> > OK. >> >> It's riscv_rtx_costs. >> >> (I don't usually read ChangeLog entries that closely, just happened to >> stumble on it when poking around.) > > Using contrib/git-commit-mklog.py can help here to make sure you > always get the correct format for the changelog and it does a decent > job of figuring out function names too. > You can also use contrib/gcc-git-customization.sh to install it such > that you can use it when doing git commits. > After invoking that inside the GCC git; you can just do "git > gcc-commit-mklog ...." Where .... would be what you normally put for > "git commit" (but as if in the toplevel directory). Thanks, that's awesome.