From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 406E93858D39 for ; Wed, 31 Aug 2022 14:57:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 406E93858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62b.google.com with SMTP id f12so14190329plb.11 for ; Wed, 31 Aug 2022 07:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date; bh=e6VgT0ZBApcxn++ZP+KhYdo6KHgSLdkVNqqWzm7i330=; b=hHV6n/yLMvpkK/+rWOxCSalKX+rPeEtzapObt9JGzS7Pu0c0TxE6mpNQNhcom8u7P2 vTgy9rOnFpcz1wlHsyQYsmR60hr8kSAw0R6EPx+IaYCYoBLx9JYot3wh9VwDrZgz9ZHV JtnQVh7Uj8W+GqRBp57ZON0LQxhVdK3M181mR9Kb2jnuVfI/gIkMWHDNku7EjK9hmQs4 WWoi1D/wQb3IYtH7I3z2N0dz0+u0gcXa5a6nDddyHCtlj9BiizAC4okI1o6d2HmgxGNV guPO6U6G+GXSp0wkNnwcE13fkA7vs2cvIt5+65qJrwPkGz1XIxCSjzR+bOF6R0LXuMAD MLuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date; bh=e6VgT0ZBApcxn++ZP+KhYdo6KHgSLdkVNqqWzm7i330=; b=3bCKxHpyEiln45QfiR9AIhCn2e8ud8Y6hDqBFuajKD/NLxglPa6i5E9s1eizbdecbp 5GHXGnFvyv5IcwIygroUgVN5II/TbCdQnEPyi7/hTYGxsiTaaKcq53xiV/BmZtsX5iYz 0YC4lXYnoU3dSJAFePdSh3JUB96opGqrB2ld/mEbf9dvyc0s6S2ER0Lg9SQ1ZzWHfsPO Qu8m8qdoLhavfcSn2Yby60tG49uOW3+kERSG6udGArjo9Y9szAusHr1ioflyD47Fz3Oj fbH0wuI4zcAPLSqb8Fk3p4/1pGQQaqYkkKuLHbS4r/TtsTnbqVhOm5BPS7ViMd+TuYw4 xBrQ== X-Gm-Message-State: ACgBeo1xtVvHn0kaeFwVulLxg2ppu6EOZSVrNOVe+Lxi/x/LpEbcs4ru QNmYzRniS5lXcFbSJeBbykc9FOCNjFF6nw== X-Google-Smtp-Source: AA6agR5erdZSzI4gR1O7rARa8IIqeqm2ZPFSfpFQJHcy7/Rbvmtd11jo6JSHzKgdTKorefpOFF6gpg== X-Received: by 2002:a17:902:780f:b0:173:5ec:f51d with SMTP id p15-20020a170902780f00b0017305ecf51dmr26384943pll.33.1661957858545; Wed, 31 Aug 2022 07:57:38 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id b4-20020a17090a7ac400b001fd9c63e56bsm1402271pjl.32.2022.08.31.07.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 07:57:38 -0700 (PDT) Date: Wed, 31 Aug 2022 07:57:38 -0700 (PDT) X-Google-Original-Date: Wed, 31 Aug 2022 07:57:24 PDT (-0700) Subject: Re: [PATCH 1/2] RISC-V: remove deprecate pic code model macro In-Reply-To: <20220830174830.224541-2-vineetg@rivosinc.com> CC: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu, collison@rivosinc.com, gnu-toolchain@rivosinc.com, Vineet Gupta From: Palmer Dabbelt To: Vineet Gupta Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Aug 2022 10:48:29 PDT (-0700), Vineet Gupta wrote: > Came across this deprecated symbol when looking around for > -mexplicit-relocs handling in code > > Signed-off-by: Vineet Gupta > --- > gcc/config/riscv/riscv-c.cc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc > index eb7ef09297e9..bba72cf77a82 100644 > --- a/gcc/config/riscv/riscv-c.cc > +++ b/gcc/config/riscv/riscv-c.cc > @@ -93,9 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) > break; > > case CM_PIC: > - /* __riscv_cmodel_pic is deprecated, and will removed in next GCC release. > - see https://github.com/riscv/riscv-c-api-doc/pull/11 */ > - builtin_define ("__riscv_cmodel_pic"); > /* FALLTHROUGH. */ > > case CM_MEDANY: It looks like some of the tests (gcc/testsuite/gcc.target/riscv/predef-3.c, for example) are checking for __riscv_cmodel_pic. From looking at them I'd expect them to fail, but even if they're not we should clean them up.