From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 698A13858401 for ; Mon, 22 Apr 2024 16:57:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 698A13858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 698A13858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713805074; cv=none; b=P3m+gEJtEdpnWtEgJcvSxPp9DPYSDqqXKcW9Bl40zyRZoh7GaMMOhSu2ZJ2WDpLo85Zp03YkmJaHPmWx51cGebtTDNaCrUMtG4XVyfU3EJDahhsV9OIHdp1smtXkVW1i6LnAWCLBtgjoJaO2Qa5hJIoszkokzDI6JirCMBl8d1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713805074; c=relaxed/simple; bh=M99olfsla7y7+ch4t8WMA1BxZP9FgMr7sUgIZp5nSHQ=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=WXUC93fQyCsYbthOVCVoP+Jj4mtax4ETuknVITHwa0MJ6HSwUxxUKdhOsHXp/fJIOCNkewyYAhhQVE6fO4CTUEpN3Poj8u2e5/5Qcb4CQO4OpJ9MtqrH8lag0k0S3BRiaH0DTd+8eBgPuCQAGLYMoehKkSsMWrkl+keJQOeCxZc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6f2f6142d64so845937b3a.2 for ; Mon, 22 Apr 2024 09:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1713805061; x=1714409861; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=iz3gNTrk58mriM/lDa3bytyWOFVXK8hj3Embt0EDVAU=; b=QHRPBI28iYEwqckm+C80VI0odcuWDw1mekGQQsIA/5ohch7+irOzoeuxzjPVZ54/30 h9irk9HmLkVJ7yVGioLzrhtnS9WZGh3bW7aOc5CLirKGBOpeB0ax+ozZVQuGZbSY2RPr 3EGIwXHQ9sZZ9EZooiw8OX8udPZWSjx4Rn44Q8yLPGgWwUCDxrW3V5NQmkWBrAS3PMUA ORv2xepQEe+DAmcoKvEK2LbveEkq0vTLC0M3KLFWsHsa9HKlNdw+h2gJLwgl/TxWn8Q1 USD3EHj1aQV9LxDVmPiYdOdwcMur8DeuATh7pglCtFhYX/zFvor2n46JDQSD4w5N667D apAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713805061; x=1714409861; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iz3gNTrk58mriM/lDa3bytyWOFVXK8hj3Embt0EDVAU=; b=q/w1C2M9113GP7OUft2i2a17+BcuYc7/0XZ8Q2eoImsQUhAzjwZU9z7+Cbip3bn+I5 vxY3LSmGd8rZZhjyWF41v0NVejkXxvK6pBwhAN2UeSAspS/GnA1o7FHmCvXkjQp8TiSL W3Xm14MduoWLXI6KyNrfX3avndv8n4OSxedHBmEp2o8Dh8pxbJEGNDpFnTjiihOdRwE2 EvUszdzQ2jNn+xRRhcgdc9DPcvnfiZgVP4DpQvZVY5v5TOX8Zh2BTWmET44tCFzHyFk6 zw5owy2xtHI2ui4dqMMnc/a+Jppi7Lxr2KA9BrZ3vNwv3Uh1j5PuLKoU4LDfTnjW8bl0 Km4w== X-Gm-Message-State: AOJu0YyCipHlPvLdY1BIbo/N8EtbARSCOSfYIie5vot7BCAQ9swBA5VI XLBacuQ+ZLcozhetYzlCmRvI1cNx/PUw1XTze0RxaDnfLw/AbsJVzPl3B6w4UzcTWUfOeng9DqR u X-Google-Smtp-Source: AGHT+IEUKud0IJsJ93MvwvqS2oqd0i5S/YQfiZxbw4JNKefafuKYqcRyCCPhDDoZZj38azbKwfCWaQ== X-Received: by 2002:a05:6a00:4fd3:b0:6e6:9f47:38c6 with SMTP id le19-20020a056a004fd300b006e69f4738c6mr13165545pfb.27.1713805060478; Mon, 22 Apr 2024 09:57:40 -0700 (PDT) Received: from localhost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id fh9-20020a056a00390900b006ecf1922df7sm8005690pfb.36.2024.04.22.09.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 09:57:39 -0700 (PDT) Date: Mon, 22 Apr 2024 09:57:39 -0700 (PDT) X-Google-Original-Date: Mon, 22 Apr 2024 09:57:37 PDT (-0700) Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 In-Reply-To: <20240422134734.1909499-1-pan2.li@intel.com> CC: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, Kito Cheng , Robin Dapp , pan2.li@intel.com From: Palmer Dabbelt To: pan2.li@intel.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 22 Apr 2024 06:47:34 PDT (-0700), pan2.li@intel.com wrote: > From: Pan Li > > After we reverted below 2 commits, the reference to attr need some > adjustment as the group_overlap is no longer available. > > * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute > * RISC-V: Rename vconstraint into group_overlap That landed as cacc55a4c0b ("Revert "RISC-V: Rename vconstraint into group_overlap""), but I can't find a review on the lists and the commit appears to not even build. Did I miss the reviews or something? > The below tests are passed for this patch. > > * The rv64gcv fully regression tests. > > gcc/ChangeLog: > > * config/riscv/vector-crypto.md: > > Signed-off-by: Pan Li > --- > gcc/config/riscv/vector-crypto.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/vector-crypto.md b/gcc/config/riscv/vector-crypto.md > index 519c6a10d94..23dc549e5b8 100755 > --- a/gcc/config/riscv/vector-crypto.md > +++ b/gcc/config/riscv/vector-crypto.md > @@ -322,7 +322,7 @@ (define_insn "@pred_vwsll_scalar" > "vwsll.v%o4\t%0,%3,%4%p1" > [(set_attr "type" "vwsll") > (set_attr "mode" "") > - (set_attr "group_overlap" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,none,none")]) > + (set_attr "vconstraint" "W21,W21,W21,W21,W42,W42,W42,W42,W84,W84,W84,W84,no,no")]) > > ;; vbrev.v vbrev8.v vrev8.v > (define_insn "@pred_v"