From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 349933857436 for ; Thu, 29 Jul 2021 19:00:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 349933857436 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pj1-x102b.google.com with SMTP id pj14-20020a17090b4f4eb029017786cf98f9so236087pjb.2 for ; Thu, 29 Jul 2021 12:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=0NnQvis3fot3nZsM4K0k7+N5jRemuk/YYH/HrQdurtA=; b=O6wo+FQBhZISKAn+YiDMv7duuLh/rYWkDBwY1p+I6ndT8lYx7j+rDmpVZck1idesxa vAhTHDF1NJTKPcX/HTjUHTntYHBfqA2fdtGRa13uEh+SrmmZte4PUtEb98X5SlrreqVF aCaDVK2+mnKKLv9tHoy5Y/eU3H3AVpDfBmFoil52nj/aS8YGIf7tisQ9+MhF4ynjuhAF m7kO5cOJCLYWt2HDVNpQ9faSxf3YqRSTo5dahv/n4wCU5dKAOF1W26r8J/bI1XZv9G// 6ayGW4SpEFmOuh3wmZAtCdETzrGhHXshWZ+gsi/Lmeufwfdp+v4zqnQxnnfNj4dvt49I b8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=0NnQvis3fot3nZsM4K0k7+N5jRemuk/YYH/HrQdurtA=; b=ViWQ69UVDhAHHF+u2N99erVMPVazu0XrSzVhClia+RRdMcSGSvp1OTEsyQyDQpzZxm azHL7YkiKqX6HmzpiLPg83WhMwTLuu7vDIoydwDA1T2KQk8fluhZtyyCt47C53z4maWK LBA/2d03PrlHKrYCJZWaHmA7NB7l4vqMdErHwvf+lLhnmFvTNh1tGo6opJSwtuAHQUNQ B2wnxc54ry3Zijct8CMtsRWrx6GXT4HeD2qq1WRz0Sfdqoi4s+X9OHRmoebxcs2gnaU7 mUKpDt7vJ/6TxZBcwCQlKlulW1KL8BwOeB/m+8LhafGhLaBqy5QN2oixE0J4QAq7JRaR 1zgQ== X-Gm-Message-State: AOAM5304suHBk9CTG7i2Pi16ha7Zu/fWrXzq79C2GjDfdZZsDO2AIU0b r38mjKu6ayrQbbUEAtQRlEEFz84PB7NrWQ== X-Google-Smtp-Source: ABdhPJxofVNrPiS8RolSfQMYGnJzmoUG3JVZfXdh8E/AcUnkg8QqMG7GBMEMJdS35L7b+wfvB9ftXg== X-Received: by 2002:a62:8347:0:b029:349:7dfc:7a6c with SMTP id h68-20020a6283470000b02903497dfc7a6cmr6481219pfe.16.1627585230237; Thu, 29 Jul 2021 12:00:30 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id j25sm3092345pfe.198.2021.07.29.12.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 12:00:29 -0700 (PDT) Date: Thu, 29 Jul 2021 12:00:29 -0700 (PDT) X-Google-Original-Date: Thu, 29 Jul 2021 12:00:28 PDT (-0700) Subject: Re: [PATCH 0/2] New target hook TARGET_COMPUTE_MULTILIB and implementation for RISC-V In-Reply-To: CC: kito.cheng@sifive.com, gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: gcc-patches@gcc.gnu.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 19:00:32 -0000 On Thu, 29 Jul 2021 11:44:09 PDT (-0700), gcc-patches@gcc.gnu.org wrote: > ping > > On Wed, Jul 21, 2021 at 5:28 PM Kito Cheng wrote: >> >> This patch set allow target to use customized multi-lib mechanism rather than the built-in >> multi-lib mechanism. >> >> The motivation of this patch is RISC-V might have very complicated multi-lib re-use >> rule*, which is hard to maintain and use current multi-lib scripts, >> we even hit the "argument list too long" error when we tried to add more >> multi-lib reuse rule. >> >> * Here is an example for RISC-V multi-lib rules: >> https://gist.github.com/kito-cheng/0289cd42d9a756382e5afeb77b42b73b >> >> V2 Changes: >> - NO changes for first patch(TARGET_COMPUTE_MULTILIB part) since first version. >> - Handle option other than -march and -mabi for riscv_compute_multilib. This generally LGTM, but I think it's the sort of thing that should be looked at by a global reviewer. There's a bit of a policy decision being made here in that this allows external hooks during the build process. I'm fine with this, as it's just the multilib list, those are really specific to a specific toolchain distribution, and there's never going to be a way to catalog all the interested cases for the embedded toolchains. I'm still not comfortable calling that a review, though, as these things are subtle and I don't always have the same bar for external bits that the rest of the GCC folks do.