From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 0FE32385802F for ; Thu, 23 Feb 2023 18:38:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FE32385802F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com Received: by mail-pf1-x42f.google.com with SMTP id bq8so762917pfb.8 for ; Thu, 23 Feb 2023 10:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=BE9ACp9A94fRRPLyymS1j2CKzdwnGyTjEMAl8IDmBWA=; b=YmXb6HIaQhjzvFcP3oo0E1OmT6msAJKV+LMLOlM5Wde9i1VBW8QMG7uzYdPC0FOIkW A8/52k6PUXUFj0+OinX9UnjiDNzKnP6grzgaLQMkLGxSXwfsZt4fgRepEemviCnbAl50 kMwisfFpJL0pNBIYSdVu5fn/2RN7Jzoeo4Li6gTjUslHVOq95ddrvPE5PSPXw2exW1Bz HHhruOQjLAd6xpjfEbueEh8irlmyGxv4yQe2kBzPLqf2MSnAa1Frz8HghbfDRHvqWsss qR3Xw/M4KcZXc1y0/vZSlTuNPjL4xDcYTRl80Ypi+y1YjKAlmbce4SuCTZrxZy81R36R WwYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BE9ACp9A94fRRPLyymS1j2CKzdwnGyTjEMAl8IDmBWA=; b=SSjPAzd5NT2h6JrOtLzvKr2VT7EH7bxPKsr3kqKPUQrNoWfPuugdJ5WjVuGiOubhvF 4ULZ9ayZy7jEaiAx2U2E6t7oipJEWqY73bdY2uhJMVIb9Z6t4NO62KSfus0+QwuulEbu yPEEfGhhYsAqigbr6xahLbfzR12GRVuQempX8i/ljLEAAyPNbhBF4LguzGIUHXe2/mjQ 2W6TB/Jw/O9XE5XNui3pyttdvHESWjEwUK+xk3CVdMpWjK5IoXdlRcZ36xDbMC7Jq89e y7RzLxtJA27Ut3N6/OYkFE27H6ySYexQ1w885Zf8bBoqnLrjsXgsuZWbGGI7k2Sl99Vu iE4g== X-Gm-Message-State: AO0yUKXWT476UOTGdU2c2k7+/kgJV25Vg4CFWa6pUjaO7owlCcIj2yBp GkhGBZAY7HqkK24l83iNSKitnw== X-Google-Smtp-Source: AK7set+AoYAKEZC3z893tV6GEhRnXFO4+ZVqsIHfKIErQ0cIcTnfKkpKS9iINiBw9VbAzzGevCl7JQ== X-Received: by 2002:aa7:97a3:0:b0:5a9:c535:dba3 with SMTP id d3-20020aa797a3000000b005a9c535dba3mr13391966pfq.25.1677177522274; Thu, 23 Feb 2023 10:38:42 -0800 (PST) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id j22-20020a62e916000000b005a831a42c86sm7593083pfh.72.2023.02.23.10.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 10:38:41 -0800 (PST) Date: Thu, 23 Feb 2023 10:38:41 -0800 (PST) X-Google-Original-Date: Thu, 23 Feb 2023 10:37:56 PST (-0800) Subject: Re: [gcc] RTEMS: Tune multilib selection In-Reply-To: <20230223114826.79148-1-sebastian.huber@embedded-brains.de> CC: devel@rtems.org, gcc-patches@gcc.gnu.org From: Palmer Dabbelt To: sebastian.huber@embedded-brains.de Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 23 Feb 2023 03:48:26 PST (-0800), sebastian.huber@embedded-brains.de wrote: > gcc/ChangeLog: > > * config/riscv/t-rtems: Keep only -mcmodel=medany 64-bit multilibs. > Add non-compact 32-bit multilibs. > --- > gcc/config/riscv/t-rtems | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/riscv/t-rtems b/gcc/config/riscv/t-rtems > index 41f5927fc87..19b12030895 100644 > --- a/gcc/config/riscv/t-rtems > +++ b/gcc/config/riscv/t-rtems > @@ -1,8 +1,8 @@ > MULTILIB_OPTIONS = > MULTILIB_DIRNAMES = > > -MULTILIB_OPTIONS += march=rv32i/march=rv32im/march=rv32imafd/march=rv32iac/march=rv32imac/march=rv32imafc/march=rv64imafd/march=rv64imac/march=rv64imafdc > -MULTILIB_DIRNAMES += rv32i rv32im rv32imafd rv32iac rv32imac rv32imafc rv64imafd rv64imac rv64imafdc > +MULTILIB_OPTIONS += march=rv32i/march=rv32iac/march=rv32im/march=rv32ima/march=rv32imac/march=rv32imaf/march=rv32imafc/march=rv32imafd/march=rv32imafdc/march=rv64ima/march=rv64imac/march=rv64imafd/march=rv64imafdc > +MULTILIB_DIRNAMES += rv32i rv32iac rv32im rv32ima rv32imac rv32imaf rv32imafc rv32imafd rv32imafdc rv64ima rv64imac rv64imafd rv64imafdc > > MULTILIB_OPTIONS += mabi=ilp32/mabi=ilp32f/mabi=ilp32d/mabi=lp64/mabi=lp64d > MULTILIB_DIRNAMES += ilp32 ilp32f ilp32d lp64 lp64d > @@ -12,14 +12,15 @@ MULTILIB_DIRNAMES += medany > > MULTILIB_REQUIRED = > MULTILIB_REQUIRED += march=rv32i/mabi=ilp32 > -MULTILIB_REQUIRED += march=rv32im/mabi=ilp32 > -MULTILIB_REQUIRED += march=rv32imafd/mabi=ilp32d > MULTILIB_REQUIRED += march=rv32iac/mabi=ilp32 > +MULTILIB_REQUIRED += march=rv32im/mabi=ilp32 > +MULTILIB_REQUIRED += march=rv32ima/mabi=ilp32 > MULTILIB_REQUIRED += march=rv32imac/mabi=ilp32 > +MULTILIB_REQUIRED += march=rv32imaf/mabi=ilp32f > MULTILIB_REQUIRED += march=rv32imafc/mabi=ilp32f > -MULTILIB_REQUIRED += march=rv64imafd/mabi=lp64d > -MULTILIB_REQUIRED += march=rv64imafd/mabi=lp64d/mcmodel=medany > -MULTILIB_REQUIRED += march=rv64imac/mabi=lp64 > +MULTILIB_REQUIRED += march=rv32imafd/mabi=ilp32d > +MULTILIB_REQUIRED += march=rv32imafdc/mabi=ilp32d > +MULTILIB_REQUIRED += march=rv64ima/mabi=lp64/mcmodel=medany > MULTILIB_REQUIRED += march=rv64imac/mabi=lp64/mcmodel=medany > -MULTILIB_REQUIRED += march=rv64imafdc/mabi=lp64d > +MULTILIB_REQUIRED += march=rv64imafd/mabi=lp64d/mcmodel=medany > MULTILIB_REQUIRED += march=rv64imafdc/mabi=lp64d/mcmodel=medany Reviewed-by: Palmer Dabbelt IMO it's fine to remove multilibs from the default set. It could be seen as breaking users, but IIRC last time we talked about something like this it was OK as otherwise we're going to end up with a huge set of multilibs for defunct ISAs. This one is also extra safe, since moving to medany shouldn't break any users (aside from maybe a slight performance issue). Are you aiming for GCC-13 with this? I wouldn't be opposed to that: there's some risk of breaking users this late in the process, but my guess is that most of them aren't looking until release anyway. Still better to hold off, but if there's something in RTEMS land that benefits from this being early then I think it's fine.