From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id F132E3858C2F for ; Tue, 12 Dec 2023 15:32:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F132E3858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F132E3858C2F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702395177; cv=none; b=H7+AxmpR/EB6hWEK8ob75QG5AKnqaHvhaA6POFYqaIwDQjkGrihyKw3gwf8J1zMi8PMeiP78c9Nj9B4Jejr72YK60q8dG+MHxxs6yrs3jkB9PF8JS12BLWSJViRTXT4JT6+ozo7tgnjjSOpHUlBV63lSliBOuOrQkeGfY6btK1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702395177; c=relaxed/simple; bh=KD9EMOboeAjTy5obUpp2J6xMb2t5JCkyNT5zMFfEtc4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Bz/eR07o3nFLKNCUvo78DyGIQdYZbEbmtrdtjAB32SlBDDPnCWoaqGbd7khFerZWvfUSHL/DMbbeio50qv6TTDHxA+L190PqpcPTq8cq+7RjaTolGXKfwAGTbLKSz5dn7DUrrlYPV81491jws8UE+APELV/Epc5S6Bjs3esrGSk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAF4C143D; Tue, 12 Dec 2023 07:33:42 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E27E33F738; Tue, 12 Dec 2023 07:32:55 -0800 (PST) From: Richard Sandiford To: Robin Dapp Mail-Followup-To: Robin Dapp ,Richard Biener , gcc-patches , "juzhe.zhong\@rivai.ai" , richard.sandiford@arm.com Cc: Richard Biener , gcc-patches , "juzhe.zhong\@rivai.ai" Subject: Re: [PATCH] expmed: Perform mask extraction via QImode [PR112773]. References: <005985aa-0ebb-4e22-b725-ffd32587d427@gmail.com> <47p8rn51-0s76-7580-6nq1-0s121n09147p@fhfr.qr> <268eacf5-2f00-4010-8f19-36aed607d2a9@gmail.com> <2102ns59-9nnr-o6p8-r806-6ssppqnqs24o@fhfr.qr> <3495a650-f113-43b0-a9ea-672d08f948b3@gmail.com> <35167f65-7f43-4d76-96da-aefe2a5f5237@gmail.com> Date: Tue, 12 Dec 2023 15:32:54 +0000 In-Reply-To: <35167f65-7f43-4d76-96da-aefe2a5f5237@gmail.com> (Robin Dapp's message of "Tue, 12 Dec 2023 16:11:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-15.8 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Robin Dapp writes: >> - Change the second mode to vec_extract_optab. This is only a name >> lookup, and it seems more natural to continue using the real element mode. > > Am I understanding correctly that this implies we should provide > a vec_extractbi expander? (with the innermode being BImode > here). Yeah, I think so. That way the interpretation of the mode stays in sync with the interpretation of the bit position. If instead we used QImode with a bitnum of , the top 7 bits of the read would logically be out of bounds. Thanks, Richard