From: Richard Sandiford <richard.sandiford@arm.com>
To: Andrew Pinski <quic_apinski@quicinc.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] aarch64: Fix __builtin_apply with -mgeneral-regs-only [PR113486]
Date: Wed, 24 Jan 2024 17:43:31 +0000 [thread overview]
Message-ID: <mpt34umhbjw.fsf@arm.com> (raw)
In-Reply-To: <20240118215730.1012858-1-quic_apinski@quicinc.com> (Andrew Pinski's message of "Thu, 18 Jan 2024 13:57:30 -0800")
Andrew Pinski <quic_apinski@quicinc.com> writes:
> The problem here is the builtin apply mechanism thinks the FP registers
> are to be used due to get_raw_arg_mode not returning VOIDmode. This
> fixes that oversight and the backend now returns VOIDmode for non-general-regs
> if TARGET_GENERAL_REGS_ONLY is true.
>
> Built and tested for aarch64-linux-gnu with no regressions.
>
> PR target/113486
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.cc (aarch64_get_reg_raw_mode): For
> TARGET_GENERAL_REGS_ONLY, return VOIDmode for non-GP_REGNUM_P regno.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/builtin_apply-1.c: New test.
OK, thanks.
Richard
> Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
> ---
> gcc/config/aarch64/aarch64.cc | 4 ++++
> gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c | 12 ++++++++++++
> 2 files changed, 16 insertions(+)
> create mode 100644 gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c
>
> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index e6bd3fd0bb4..a838cbba51d 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -7221,6 +7221,10 @@ aarch64_function_arg_boundary (machine_mode mode, const_tree type)
> static fixed_size_mode
> aarch64_get_reg_raw_mode (int regno)
> {
> + /* Don't use any non GP registers for __builtin_apply and
> + __builtin_return if general registers only mode is requested. */
> + if (TARGET_GENERAL_REGS_ONLY && !GP_REGNUM_P (regno))
> + return as_a <fixed_size_mode> (VOIDmode);
> if (TARGET_SVE && FP_REGNUM_P (regno))
> /* Don't use the SVE part of the register for __builtin_apply and
> __builtin_return. The SVE registers aren't used by the normal PCS,
> diff --git a/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c b/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c
> new file mode 100644
> index 00000000000..d70abe037d2
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/builtin_apply-1.c
> @@ -0,0 +1,12 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mgeneral-regs-only" } */
> +/* PR target/113486 */
> +
> +
> +/* __builtin_apply should not use FP registers if
> + general registers only mode is requested. */
> +void
> +foo (void)
> +{
> + __builtin_apply (foo, 0, 0);
> +}
prev parent reply other threads:[~2024-01-24 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 21:57 Andrew Pinski
2024-01-24 17:43 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpt34umhbjw.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=quic_apinski@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).