public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: <gcc-patches@gcc.gnu.org>,
	 Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	 <Joe.Ramsay@arm.com>
Subject: Re: [PATCH] aarch64: fortran: Adjust vect-8.f90 for libmvec
Date: Fri, 29 Dec 2023 10:26:58 +0000	[thread overview]
Message-ID: <mpt34vlfgnh.fsf@arm.com> (raw)
In-Reply-To: <20231228124119.2777672-1-szabolcs.nagy@arm.com> (Szabolcs Nagy's message of "Thu, 28 Dec 2023 12:41:19 +0000")

Szabolcs Nagy <szabolcs.nagy@arm.com> writes:
> With new glibc one more loop can be vectorized via simd exp in libmvec.
>
> Found by the Linaro TCWG CI.
>
> gcc/testsuite/ChangeLog:
>
> 	* gfortran/vect/vect-8.f90: Accept more vectorized loops.

OK.  At first I thought it would be good to "defend" the increase when
it's supposed to apply, but it would need a relatively complicated check,
and there should be plenty of test coverage elsewhere.

Thanks,
Richard

> ---
>  gcc/testsuite/gfortran.dg/vect/vect-8.f90 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gfortran.dg/vect/vect-8.f90 b/gcc/testsuite/gfortran.dg/vect/vect-8.f90
> index ca72ddcffca..938dfc29754 100644
> --- a/gcc/testsuite/gfortran.dg/vect/vect-8.f90
> +++ b/gcc/testsuite/gfortran.dg/vect/vect-8.f90
> @@ -704,7 +704,7 @@ CALL track('KERNEL  ')
>  RETURN
>  END SUBROUTINE kernel
>  
> -! { dg-final { scan-tree-dump-times "vectorized 25 loops" 1 "vect" { target aarch64_sve } } }
> -! { dg-final { scan-tree-dump-times "vectorized 24 loops" 1 "vect" { target { aarch64*-*-* && { ! aarch64_sve } } } } }
> +! { dg-final { scan-tree-dump-times "vectorized 2\[56\] loops" 1 "vect" { target aarch64_sve } } }
> +! { dg-final { scan-tree-dump-times "vectorized 2\[45\] loops" 1 "vect" { target { aarch64*-*-* && { ! aarch64_sve } } } } }
>  ! { dg-final { scan-tree-dump-times "vectorized 2\[234\] loops" 1 "vect" { target { vect_intdouble_cvt && { ! aarch64*-*-* } } } } }
>  ! { dg-final { scan-tree-dump-times "vectorized 17 loops" 1 "vect" { target { { ! vect_intdouble_cvt } && { ! aarch64*-*-* } } } } }

      reply	other threads:[~2023-12-29 10:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28 12:41 Szabolcs Nagy
2023-12-29 10:26 ` Richard Sandiford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mpt34vlfgnh.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=Joe.Ramsay@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).