From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 4D6893858D33 for ; Fri, 29 Dec 2023 10:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D6893858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D6893858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703845621; cv=none; b=NZYn8ze/mkRyllnL8gEhiCIfKikIDsnIcW95lVEBQFBmilwEzc8TMAt3aGcQEnpgs/Uz6GWC77qpXstzKFFfiJXxxyGg+40S8vrblsooiogpea2oWh7SRwlURO9cVagQMA66i9D6troKOZaRbcWVj3JwandSMnsmp97DPNIyTeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703845621; c=relaxed/simple; bh=SWO0T/IEDbYv2PW6ohEU98QO1OtfiXB20wOs3OVeums=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=XyOAGTvC/dMKgGDng4EdZXDcoJOHYYIszhFyv7bYVv+9OZEGqUv+rEQv6Unv0SlGBKH2Jv7G87bpO+Wibj/bVVY4MCpk8R5DwczXwyPgvWgcDj566lcax4KPNPyYOEwo1SQrv39LIzJIWoSMyshVVxif1MSfHHq8sX77UgkSSTU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 567F02F4; Fri, 29 Dec 2023 02:27:46 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3C1FE3F64C; Fri, 29 Dec 2023 02:26:59 -0800 (PST) From: Richard Sandiford To: Szabolcs Nagy Mail-Followup-To: Szabolcs Nagy ,, Maxim Kuvyrkov , , richard.sandiford@arm.com Cc: , Maxim Kuvyrkov , Subject: Re: [PATCH] aarch64: fortran: Adjust vect-8.f90 for libmvec References: <20231228124119.2777672-1-szabolcs.nagy@arm.com> Date: Fri, 29 Dec 2023 10:26:58 +0000 In-Reply-To: <20231228124119.2777672-1-szabolcs.nagy@arm.com> (Szabolcs Nagy's message of "Thu, 28 Dec 2023 12:41:19 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-21.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Szabolcs Nagy writes: > With new glibc one more loop can be vectorized via simd exp in libmvec. > > Found by the Linaro TCWG CI. > > gcc/testsuite/ChangeLog: > > * gfortran/vect/vect-8.f90: Accept more vectorized loops. OK. At first I thought it would be good to "defend" the increase when it's supposed to apply, but it would need a relatively complicated check, and there should be plenty of test coverage elsewhere. Thanks, Richard > --- > gcc/testsuite/gfortran.dg/vect/vect-8.f90 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gfortran.dg/vect/vect-8.f90 b/gcc/testsuite/gfortran.dg/vect/vect-8.f90 > index ca72ddcffca..938dfc29754 100644 > --- a/gcc/testsuite/gfortran.dg/vect/vect-8.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/vect-8.f90 > @@ -704,7 +704,7 @@ CALL track('KERNEL ') > RETURN > END SUBROUTINE kernel > > -! { dg-final { scan-tree-dump-times "vectorized 25 loops" 1 "vect" { target aarch64_sve } } } > -! { dg-final { scan-tree-dump-times "vectorized 24 loops" 1 "vect" { target { aarch64*-*-* && { ! aarch64_sve } } } } } > +! { dg-final { scan-tree-dump-times "vectorized 2\[56\] loops" 1 "vect" { target aarch64_sve } } } > +! { dg-final { scan-tree-dump-times "vectorized 2\[45\] loops" 1 "vect" { target { aarch64*-*-* && { ! aarch64_sve } } } } } > ! { dg-final { scan-tree-dump-times "vectorized 2\[234\] loops" 1 "vect" { target { vect_intdouble_cvt && { ! aarch64*-*-* } } } } } > ! { dg-final { scan-tree-dump-times "vectorized 17 loops" 1 "vect" { target { { ! vect_intdouble_cvt } && { ! aarch64*-*-* } } } } }