From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id A59C13858430 for ; Thu, 19 Jan 2023 09:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A59C13858430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDB4F1758; Thu, 19 Jan 2023 01:23:47 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A42F03F71A; Thu, 19 Jan 2023 01:23:05 -0800 (PST) From: Richard Sandiford To: Christophe Lyon Mail-Followup-To: Christophe Lyon ,, , richard.sandiford@arm.com Cc: , Subject: Re: [PATCH 2/2] aarch64: add -fno-stack-protector to some tests [PR108411] References: <20230118201649.11612-1-christophe.lyon@arm.com> <20230118201649.11612-2-christophe.lyon@arm.com> Date: Thu, 19 Jan 2023 09:23:04 +0000 In-Reply-To: <20230118201649.11612-2-christophe.lyon@arm.com> (Christophe Lyon's message of "Wed, 18 Jan 2023 21:16:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-37.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Christophe Lyon writes: > As discussed in the PR, these recently added tests fail when the > testsuite is executed with -fstack-protector-strong. To avoid this, > this patch adds -fno-stack-protector to dg-options. > > PR target/108411 > gcc/testsuite > * g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C: Add > -fno-stack-protector. > * g++.target/aarch64/bitfield-abi-warning-align16-O2.C: Likewise. > * g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C: Likewise. > * g++.target/aarch64/bitfield-abi-warning-align32-O2.C: Likewise. > * g++.target/aarch64/bitfield-abi-warning-align8-O2.C: Likewise. > * gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c: Likewise. > * gcc.target/aarch64/bitfield-abi-warning-align16-O2.c: Likewise. > * gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c: Likewise. > * gcc.target/aarch64/bitfield-abi-warning-align32-O2.c: Likewise. > * gcc.target/aarch64/bitfield-abi-warning-align8-O2.c: Likewise. OK, thanks. Richard > --- > .../g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C | 2 +- > .../g++.target/aarch64/bitfield-abi-warning-align16-O2.C | 2 +- > .../g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C | 2 +- > .../g++.target/aarch64/bitfield-abi-warning-align32-O2.C | 2 +- > .../g++.target/aarch64/bitfield-abi-warning-align8-O2.C | 2 +- > .../gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c | 2 +- > .../gcc.target/aarch64/bitfield-abi-warning-align16-O2.c | 2 +- > .../gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c | 2 +- > .../gcc.target/aarch64/bitfield-abi-warning-align32-O2.c | 2 +- > .../gcc.target/aarch64/bitfield-abi-warning-align8-O2.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C > index 443cd458b4c..52f9cdd1ee9 100644 > --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C > +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */ > > #define ALIGN 16 > //#define EXTRA > diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C > index 76a7e3d0ad4..9ff4e46645b 100644 > --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C > +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align16-O2.C > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */ > > #define ALIGN 16 > #define EXTRA > diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C > index 6f8f54f41ff..55dcbfe4b7c 100644 > --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C > +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */ > > #define ALIGN 32 > //#define EXTRA > diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C > index 6b8ad5fbea1..6bb8778ee90 100644 > --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C > +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align32-O2.C > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */ > > #define ALIGN 32 > #define EXTRA > diff --git a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C > index b1764d97ea0..41bcc894a2b 100644 > --- a/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C > +++ b/gcc/testsuite/g++.target/aarch64/bitfield-abi-warning-align8-O2.C > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps -Wno-narrowing" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps -Wno-narrowing" } */ > > #define ALIGN 8 > #define EXTRA > diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c > index f248a129509..3b2c932ac23 100644 > --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c > +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */ > > #define ALIGN 16 > //#define EXTRA > diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c > index 22ee5ec4c92..ee5d6faa428 100644 > --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c > +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align16-O2.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */ > > #define ALIGN 16 > #define EXTRA > diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c > index a8a50b35e8e..6d4a883a96e 100644 > --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c > +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */ > > #define ALIGN 32 > //#define EXTRA > diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c > index e872de3dbe0..331daba354c 100644 > --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c > +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align32-O2.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */ > > #define ALIGN 32 > #define EXTRA > diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c > index cb2a945a819..e6d45f5dd5c 100644 > --- a/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c > +++ b/gcc/testsuite/gcc.target/aarch64/bitfield-abi-warning-align8-O2.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -save-temps" } */ > +/* { dg-options "-O2 -fno-stack-protector -save-temps" } */ > > #define ALIGN 8 > #define EXTRA