public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Robin Dapp <rdapp@linux.ibm.com>
Cc: "Kewen.Lin" <linkw@linux.ibm.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] vect: Add bias parameter for partial vectorization
Date: Tue, 14 Dec 2021 11:47:30 +0000	[thread overview]
Message-ID: <mpt35mvif1p.fsf@arm.com> (raw)
In-Reply-To: <c86f0208-a517-e6c7-bb62-f94611b4522f@linux.ibm.com> (Robin Dapp's message of "Mon, 13 Dec 2021 19:51:12 +0100")

Robin Dapp <rdapp@linux.ibm.com> writes:
> Hi Richard,
>
> I incorporated all your remarks (sorry for the hunk from a different
> branch) except for this one:
>
>> Think it would be better to make it:
>> 
>> 	  if (use_bias_adjusted_len)
>> 	    {
>> 	      gcc_assert (i == 0);
>> 
>> But do we need to do this?  Code should only care about the final value,
>> so I didn't think we would need to keep the intermediate unbiased length
>> alongside the biased one.  (Or maybe we do.  My memory is a bit rusty,
>> sorry.)
>
> I'd agree that we generally don't need to keep the unbiased length.
> However "loop_len" being a phi node, I wasn't sure how or where to
> properly apply the bias (except via creating a new variable like I did).
>  Would be thankful about a pointer here.

Ah, I see.  Yeah, I guess the loop manip stuff does still need
access to the unbiased value, so I agree we should keep both.

Thanks,
Richard

  reply	other threads:[~2021-12-14 11:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 14:44 Robin Dapp
2021-10-29  3:10 ` Kewen.Lin
2021-10-29  7:46 ` Richard Sandiford
2021-11-02 20:16   ` Robin Dapp
2021-11-04  3:59     ` Kewen.Lin
2021-11-12  9:56       ` Robin Dapp
2021-11-22  6:55         ` Kewen.Lin
2021-12-07 11:52           ` Robin Dapp
2021-12-10 19:21             ` Richard Sandiford
2021-12-13 18:51               ` Robin Dapp
2021-12-14 11:47                 ` Richard Sandiford [this message]
2022-01-10 12:53               ` Robin Dapp
2022-01-10 14:21                 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mpt35mvif1p.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linkw@linux.ibm.com \
    --cc=rdapp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).