Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

[Richard Sandiford <richard.sandiford@arm.com>]

Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
> On Thu, 30 May 2019 at 15:10, Richard Sandiford
> <richard.sandiford@arm.com> wrote:
>>
>> Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
>> > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c
>> > new file mode 100644
>> > index 00000000000..cbfeff4a59c
>> > --- /dev/null
>> > +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c
>> > @@ -0,0 +1,27 @@
>> > +/* { dg-do compile { target aarch64_asm_sve_ok } } */
>> > +/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 --save-temps" } */
>>
>> Sorry for not noticing last time, but the combination of aarch64_asm_sve_ok
>> and --save-temps only makes sense for assemble tests, not compile tests.
>> So these should either be:
>>
>> /* { dg-do assemble { target aarch64_asm_sve_ok } } */
>> /* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 --save-temps" } */
>>
>> or:
>>
>> /* { dg-do compile } */
>> /* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256" } */
>>
>> Might as well as go for the first I guess.  Same for the other
>> non-run tests.
>>
>> OK with that change, thanks.
> Thanks for pointing out, updated the patch with dg-do assemble.
> Sorry for silly ques - What configure option should be passed to gcc
> to generate code with -msve-vector-bits=256 by default ?
> I suppose that'd be necessary for correctness testing, to test patch
> with run tests that contain initializers and don't explicitly pass
> -msve-vector-bits=256 ?

There's no configure option, but you can test with things like
--target_board unix/-msve-vector-bits=256 or
--target_board unix{,/-msve-vector-bits=256} (to test both with
and without -msve-vector-bits=256).

Richard