From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HREa=LO=arm.com=richard.sandiford@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id 8CF2F385841C
	for <gcc-patches@gcc.gnu.org>; Tue,  9 Apr 2024 15:43:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CF2F385841C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8CF2F385841C
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712677400; cv=none;
	b=BaSHr/Z30Wqg/OxNdvzy2xUonSwxW0TxXD4cK7pIWcQKViobl21vBfJ3P/qsS8A2WOUvT0pPuf65tNvl1v5vlqGSqmoq8SnBoL/G9dEwMl1PFuKNn3gQ+l/Fi1NxiZWShTn82oidss6DNRl2QQCd+IjrfP0OraRkvfSadmec4pY=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1712677400; c=relaxed/simple;
	bh=LMJ4162Ood0fsxOEanhbDjeRlByYYwfuMYLuW1x3pTg=;
	h=From:To:Subject:Date:Message-ID:MIME-Version; b=DUt0dJCiyWpsvTlglJHr4E0jOQuU8OcmKWDWq580SbaBmnDILtCYXsAWxpdD8d3FxVOJhU7M4iiOAmwKZY3fdT/ROqbPizeHzErNVUp8AK56BPjungnUE0T3nzjI0oIE1k5QBcT8j6TrODfaLlTJ6gPOUwYZY0vlNsFSUD84fmY=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79692139F;
	Tue,  9 Apr 2024 08:43:48 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFB103F6C4;
	Tue,  9 Apr 2024 08:43:17 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Andrew Carlotti <andrew.carlotti@arm.com>
Mail-Followup-To: Andrew Carlotti <andrew.carlotti@arm.com>,gcc-patches@gcc.gnu.org,  Richard Earnshaw <richard.earnshaw@arm.com>, richard.sandiford@arm.com
Cc: gcc-patches@gcc.gnu.org,  Richard Earnshaw <richard.earnshaw@arm.com>
Subject: Re: [PATCH 0/5] aarch64: FMV feature list fixes
References: <33371799-7353-cd99-3f78-9abe31ad24ec@e124511.cambridge.arm.com>
Date: Tue, 09 Apr 2024 16:43:16 +0100
In-Reply-To: <33371799-7353-cd99-3f78-9abe31ad24ec@e124511.cambridge.arm.com>
	(Andrew Carlotti's message of "Tue, 9 Apr 2024 14:24:13 +0100")
Message-ID: <mpt4jcav8x7.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Andrew Carlotti <andrew.carlotti@arm.com> writes:
> The first three patches are trivial changes to the feature list to reflect
> recent changes in the ACLE.  Patch 4 removes most of the FMV multiversioning
> features that don't work at the moment, and should be entirely uncontroversial.
>
> Patch 5 handles the remaining cases, where there's an inconsistency in how
> features are named in the current FMV specification compared to the existing
> command line options.  It might be better to instead preserve the "memtag2",
> "ssbs2" and "ls64_accdata" names for now; I'd be happy to commit either
> version.

Yeah, I suppose patch 5 leaves things in a somewhat awkward state,
since e.g.:

-AARCH64_OPT_FMV_EXTENSION("memtag", MEMTAG, (), (), (), "")
+AARCH64_OPT_EXTENSION("memtag", MEMTAG, (), (), (), "")
 
-AARCH64_FMV_FEATURE("memtag2", MEMTAG2, (MEMTAG))
+AARCH64_FMV_FEATURE("memtag", MEMTAG2, (MEMTAG))

seems to drop "memtag2" and FEAT_MEMTAG, but keep "memtag" and
FEAT_MEMTAG2.  Is that right?

Apart from that and the comment on patch 2, the series looks good to me.

While rechecking aarch64-option-extensions.def against the ACLE list:
it seems that the .def doesn't treat mops as an FMV feature.  Is that
deliberate?

Thanks,
Richard