From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id E31F13858D35 for ; Mon, 2 Oct 2023 07:50:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E31F13858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F05CBC15; Mon, 2 Oct 2023 00:51:03 -0700 (PDT) Received: from localhost (unknown [10.32.110.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED5E13F5A1; Mon, 2 Oct 2023 00:50:24 -0700 (PDT) From: Richard Sandiford To: Jan-Benedict Glaw Mail-Followup-To: Jan-Benedict Glaw ,gcc-patches@gcc.gnu.org, jakub@redhat.com, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, jakub@redhat.com Subject: Re: [PATCH] Remove poly_int_pod References: <20231002074757.GK31556@lug-owl.de> Date: Mon, 02 Oct 2023 08:50:23 +0100 In-Reply-To: <20231002074757.GK31556@lug-owl.de> (Jan-Benedict Glaw's message of "Mon, 2 Oct 2023 09:47:57 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-18.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jan-Benedict Glaw writes: > Hi Richard, > > On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford wrote: >> poly_int was written before the switch to C++11 and so couldn't >> use explicit default constructors. This led to an awkward split >> between poly_int_pod and poly_int. poly_int simply inherited from >> poly_int_pod and added constructors, with the argumentless constructor >> having an empty body. But inheritance meant that poly_int had to >> repeat the assignment operators from poly_int_pod (again, no C++11, >> so no "using" to inherit base-class implementations). > [...] > > I haven't bisected it, but I guess your patch caused this: > > [all 2023-10-02 06:59:02] /var/lib/laminar/run/gcc-local/75/local-toolchain-install/bin/g++ -std=c++11 -fno-PIE -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -fno-PIE -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o rtl-tests.o -MT rtl-tests.o -MMD -MP -MF ./.deps/rtl-tests.TPo ../../gcc/gcc/rtl-tests.cc > [all 2023-10-02 06:59:04] In file included from ../../gcc/gcc/coretypes.h:480, > [all 2023-10-02 06:59:04] from ../../gcc/gcc/rtl-tests.cc:22: > [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h: In instantiation of 'constexpr poly_int::poly_int(poly_int_full, const Cs& ...) [with Cs = {int, int}; unsigned int N = 1; C = long int]': > [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h:439:13: required from here > [all 2023-10-02 06:59:04] ../../gcc/gcc/rtl-tests.cc:249:25: in 'constexpr' expansion of 'poly_int<1, long int>(1, 1)' > [all 2023-10-02 06:59:04] ../../gcc/gcc/poly-int.h:453:5: error: too many initializers for 'long int [1]' > [all 2023-10-02 06:59:04] 453 | : coeffs { (typename poly_coeff_traits:: > [all 2023-10-02 06:59:04] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > [all 2023-10-02 06:59:04] 454 | template init_cast::type (cs))... } {} > [all 2023-10-02 06:59:04] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > [all 2023-10-02 06:59:04] make[1]: *** [Makefile:1188: rtl-tests.o] Error 1 > [all 2023-10-02 06:59:04] make[1]: Leaving directory '/var/lib/laminar/run/gcc-local/75/toolchain-build/gcc' > [all 2023-10-02 06:59:05] make: *** [Makefile:4993: all-gcc] Error 2 > > > (Full build log at > http://toolchain.lug-owl.de/laminar/jobs/gcc-local/75 . That's in a > Docker container on amd64-linux with the host gcc being at fairly new > at basepoints/gcc-14-3827-g30e6ee07458) Yeah, this was PR111642. I pushed a fix this morning. Thanks, Richard