Review request summary

Review request summary

[Vasee Vinayagamoorthy]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hello,

The commit [1], as referenced below, which added a new test case,
contains a typo in the dg-final directive, which eventually causes
the gcc.log file to not be produced. This patch fixes the typo.

Tested by running regressions for aarch64-none-elf.

OK for trunk?




gcc/testsuite/ChangeLog:

2020-03-11  Vasee Vinayagamoorthy  <vaseeharan.vinayagamoorthy@arm.com\>

	* gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c: Fix DejaGnu typo.


Regards
Vasee Vinayagamoorthy

PS: I do not have commit rights, therefore could I request
someone to commit it on my behalf if this patch is approved.
Thanks in advance.

[1] https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1f520d3412962e22b0338461d82f41abba8a4f12

[-- Attachment #2: dejagnu-typo.patch --]
[-- Type: text/x-diff, Size: 691 bytes --]

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
index c2631a541ea..05c305840b6 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
@@ -1,7 +1,7 @@
 /* { dg-do assemble { target { aarch64*-*-* } } } */
 /* { dg-require-effective-target aarch64_asm_bf16_ok } */
 /* { dg-additional-options "-save-temps -march=armv8.2-a+bf16+nosimd" } */
-/* { dg-final { check-function-bodies "**" "" "-O[^0]" } } */
+/* { dg-final { check-function-bodies "**" "" {-O[^0]} } } */
 
 #include <arm_neon.h>
 

Re: Review request summary

[Richard Sandiford]

Vasee Vinayagamoorthy <vaseeharan.vinayagamoorthy@arm.com> writes:
> Hello,
>
> The commit [1], as referenced below, which added a new test case,
> contains a typo in the dg-final directive, which eventually causes
> the gcc.log file to not be produced. This patch fixes the typo.
>
> Tested by running regressions for aarch64-none-elf.
>
> OK for trunk?
>
>
>
>
> gcc/testsuite/ChangeLog:
>
> 2020-03-11  Vasee Vinayagamoorthy  <vaseeharan.vinayagamoorthy@arm.com\>

(stray backslash btw, probably a mailer-ism)

>
> 	* gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c: Fix DejaGnu typo.

Looks good, thanks, and sorry again for messing this up.

Pushed to master.

Richard
>
>
> Regards
> Vasee Vinayagamoorthy
>
> PS: I do not have commit rights, therefore could I request
> someone to commit it on my behalf if this patch is approved.
> Thanks in advance.
>
> [1] https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1f520d3412962e22b0338461d82f41abba8a4f12
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
> index c2631a541ea..05c305840b6 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/bfcvt-nosimd.c
> @@ -1,7 +1,7 @@
>  /* { dg-do assemble { target { aarch64*-*-* } } } */
>  /* { dg-require-effective-target aarch64_asm_bf16_ok } */
>  /* { dg-additional-options "-save-temps -march=armv8.2-a+bf16+nosimd" } */
> -/* { dg-final { check-function-bodies "**" "" "-O[^0]" } } */
> +/* { dg-final { check-function-bodies "**" "" {-O[^0]} } } */
>  
>  #include <arm_neon.h>
>