From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101653 invoked by alias); 17 Sep 2019 14:53:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101645 invoked by uid 89); 17 Sep 2019 14:53:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2019 14:53:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3E6315A2; Tue, 17 Sep 2019 07:53:51 -0700 (PDT) Received: from localhost (dashpi.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD3493F575; Tue, 17 Sep 2019 07:53:50 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org,nickc@redhat.com, richard.earnshaw@arm.com, ramana.radhakrishnan@arm.com, kyrylo.tkachov@arm.com, richard.sandiford@arm.com Cc: nickc@redhat.com, richard.earnshaw@arm.com, ramana.radhakrishnan@arm.com, kyrylo.tkachov@arm.com Subject: [arm] Fix insn type of *thumb1_tablejump Date: Tue, 17 Sep 2019 14:53:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg01006.txt.bz2 *thumb1_tablejump had type "no_insn", which doesn't seems to correspond to its documented use: an insn which does not represent an instruction in the final output, thus having no impact on scheduling. Indirect jumps use the same instruction and have type "branch", so the patch uses "branch" here too. Tested on armeb-none-eabi. OK to install? Richard 2019-09-17 Richard Sandiford gcc/ * config/arm/thumb1.md (*thumb1_tablejump): Change type from "no_insn" to "branch". Index: gcc/config/arm/thumb1.md =================================================================== --- gcc/config/arm/thumb1.md 2019-07-01 09:37:07.224524452 +0100 +++ gcc/config/arm/thumb1.md 2019-09-17 15:52:16.454952314 +0100 @@ -1944,7 +1944,7 @@ (define_insn "*thumb1_tablejump" "TARGET_THUMB1" "mov\\t%|pc, %0" [(set_attr "length" "2") - (set_attr "type" "no_insn")] + (set_attr "type" "branch")] ) (define_insn_and_split "thumb_eh_return"