From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 404C83858D35; Thu, 12 Jan 2023 16:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 404C83858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10B3AAD7; Thu, 12 Jan 2023 08:28:04 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E33013F587; Thu, 12 Jan 2023 08:27:20 -0800 (PST) From: Richard Sandiford To: Lulu Cheng Mail-Followup-To: Lulu Cheng ,gcc-patches@gcc.gnu.org, pinskia@gcc.gnu.org, xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn, Yang Yujie , richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, pinskia@gcc.gnu.org, xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn, Yang Yujie Subject: Re: [PATCH v4] LoongArch: Fixed a compilation failure with '%c' in inline assembly [PR107731]. References: <20221227064246.2149251-1-chenglulu@loongson.cn> <01a9ab90-fbb4-c581-a92f-f1e7c23d4580@loongson.cn> Date: Thu, 12 Jan 2023 16:27:19 +0000 In-Reply-To: <01a9ab90-fbb4-c581-a92f-f1e7c23d4580@loongson.cn> (Lulu Cheng's message of "Fri, 30 Dec 2022 14:12:47 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-37.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for doing this and sorry for the slow review. Lulu Cheng writes: > Hi, Richard: > > =C2=A0Could you please help me look at this document? Is there any probl= em=20 > with my modification? > > Thanks! > > > =E5=9C=A8 2022/12/27 =E4=B8=8B=E5=8D=882:42, Lulu Cheng =E5=86=99=E9=81= =93: >> Co-authored-by: Yang Yujie >> >> gcc/ChangeLog: >> >> * config/loongarch/loongarch.cc (loongarch_classify_address): >> Add precessint for CONST_INT. >> (loongarch_print_operand_reloc): Operand modifier 'c' is supported. >> (loongarch_print_operand): Increase the processing of '%c'. >> * doc/extend.texi: Adds documents for LoongArch operand modifiers. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/loongarch/tst-asm-const.c: Moved to... >> * gcc.target/loongarch/pr107731.c: ...here. >> >> --- >> V2 -> v3: >> 1. Correct a clerical error. >> 2. Adding document for loongarch operand modifiers. >> >> v3 -> v4: >> Copy the description of "%c" "%n" "%a" "%l" from gccint.pdf to gcc.pdf. >> >> >> --- >> gcc/config/loongarch/loongarch.cc | 14 ++++++++ >> gcc/doc/extend.texi | 33 +++++++++++++++++++ >> .../loongarch/{tst-asm-const.c =3D> pr107731.c} | 6 ++-- >> 3 files changed, 50 insertions(+), 3 deletions(-) >> rename gcc/testsuite/gcc.target/loongarch/{tst-asm-const.c =3D> pr1077= 31.c} (78%) >> >> diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/lo= ongarch.cc >> index c6b03fcf2f9..cdf190b985e 100644 >> --- a/gcc/config/loongarch/loongarch.cc >> +++ b/gcc/config/loongarch/loongarch.cc >> @@ -2075,6 +2075,11 @@ loongarch_classify_address (struct loongarch_addr= ess_info *info, rtx x, >> return (loongarch_valid_base_register_p (info->reg, mode, strict= _p) >> && loongarch_valid_lo_sum_p (info->symbol_type, mode, >> info->offset)); >> + case CONST_INT: >> + /* Small-integer addresses don't occur very often, but they >> + are legitimate if $r0 is a valid base register. */ >> + info->type =3D ADDRESS_CONST_INT; >> + return IMM12_OPERAND (INTVAL (x)); >>=20=20=20 >> default: >> return false; >> @@ -4933,6 +4938,7 @@ loongarch_print_operand_reloc (FILE *file, rtx op,= bool hi64_part, >>=20=20=20 >> 'A' Print a _DB suffix if the memory model requires a release. >> 'b' Print the address of a memory operand, without offset. >> + 'c' Print an integer. >> 'C' Print the integer branch condition for comparison OP. >> 'd' Print CONST_INT OP in decimal. >> 'F' Print the FPU branch condition for comparison OP. >> @@ -4979,6 +4985,14 @@ loongarch_print_operand (FILE *file, rtx op, int = letter) >> fputs ("_db", file); >> break; >>=20=20=20 >> + case 'c': >> + if (CONST_INT_P (op)) >> + fprintf (file, HOST_WIDE_INT_PRINT_DEC, INTVAL (op)); >> + else >> + output_operand_lossage ("unsupported operand for code '%c'", letter); >> + >> + break; >> + >> case 'C': >> loongarch_print_int_branch_condition (file, code, letter); >> break; >> diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi >> index adba057c190..1bb960266ed 100644 >> --- a/gcc/doc/extend.texi >> +++ b/gcc/doc/extend.texi >> @@ -10234,6 +10234,24 @@ generates multiple assembler instructions. >> Outputs @samp{@{}, @samp{|}, and @samp{@}} characters (respectively) >> into the assembler code. When unescaped, these characters have special >> meaning to indicate multiple assembler dialects, as described below. >> + >> +@item %c@var{digit} >> +It can be used to substitute an operand that is a constant value without >> +the syntax that normally indicates an immediate operand. It would probably more idiomatic not to have the "it" for this kind of list, so maybe: Substitutes a constant value without the syntax that normally indicates an immediate operand. Similarly for %a and %l. >> + >> +@item %n@var{digit} >> +It's like @samp{%c@var{digit}} except that the value of the constant is >> +negated before printing. Similarly here, I think just "Like ...", without the "It's". >> +@item %a@var{digit} >> +It Can be used to substitute an operand as if it were a memory referenc= e, >> +with the actual operand treated as the address. This may be useful when >> +outputting a ``load address'' instruction, because often the assembler >> +syntax for such an instruction requires you to write the operand as if = it >> +were a memory reference. >> + >> +@item %l@var{digit} >> +It's used to substitute a @code{label_ref} into a jump instruction. >> @end table This list is describing uses of % that don't relate to operands. The idea of using % with operand numbers is only introduced later, in: @code{asm} supports operand modifiers on operands (for example @samp{%k= 2}=20 instead of simply @samp{%2}). Typically these qualifiers are hardware=20 dependent. The list of supported modifiers for x86 is found at=20 @ref{x86Operandmodifiers,x86 Operand modifiers}. There are two copies of this, one for outputs and one for inputs. So I think we should instead extend that paragraph to refer to a section that contains target-independent modifiers. Maybe something like: @code{asm} supports operand modifiers on operands (for example @samp{%k= 2}=20 instead of simply @samp{%2}). @ref{genericOperandmodifiers, Generic Operand modifiers} lists the modifiers that are available on all targets. Other modifiers are hardware dependent. For example, the list of supported modifiers for x86 is found at=20 @ref{x86Operandmodifiers,x86 Operand modifiers}. Thanks, Richard >> @subsubheading Multiple assembler dialects in @code{asm} templates >> @@ -11374,6 +11392,21 @@ constant. Used to select the specified bit pos= ition. >> @item @code{x} @tab Equivialent to @code{X}, but only for pointers. >> @end multitable >>=20=20=20 >> +@anchor{loongarchOperandmodifiers} >> +@subsubsection LoongArch Operand Modifiers >> + >> +The list below describes the supported modifiers and their effects for = LoongArch. >> + >> +@multitable @columnfractions .10 .90 >> +@headitem Modifier @tab Description >> +@item @code{d} @tab Same as @code{c}. >> +@item @code{i} @tab Print the character ''@code{i}'' if the operand is = not a register. >> +@item @code{m} @tab Same as @code{c}, but the printed value is @code{op= erand - 1}. >> +@item @code{X} @tab Print a constant integer operand in hexadecimal. >> +@item @code{z} @tab Print the operand in its unmodified form, followed = by a comma. >> +@end multitable >> + >> + >> @lowersections >> @include md.texi >> @raisesections >> diff --git a/gcc/testsuite/gcc.target/loongarch/tst-asm-const.c b/gcc/te= stsuite/gcc.target/loongarch/pr107731.c >> similarity index 78% >> rename from gcc/testsuite/gcc.target/loongarch/tst-asm-const.c >> rename to gcc/testsuite/gcc.target/loongarch/pr107731.c >> index 2e04b99e301..80d84c48c6e 100644 >> --- a/gcc/testsuite/gcc.target/loongarch/tst-asm-const.c >> +++ b/gcc/testsuite/gcc.target/loongarch/pr107731.c >> @@ -1,13 +1,13 @@ >> -/* Test asm const. */ >> /* { dg-do compile } */ >> /* { dg-final { scan-assembler-times "foo:.*\\.long 1061109567.*\\.lon= g 52" 1 } } */ >> + >> int foo () >> { >> __asm__ volatile ( >> "foo:" >> "\n\t" >> - ".long %a0\n\t" >> - ".long %a1\n\t" >> + ".long %c0\n\t" >> + ".long %c1\n\t" >> : >> :"i"(0x3f3f3f3f), "i"(52) >> :