public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Joern Rennecke <joern.rennecke@embecosm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: Fix match_scratch bug in define_subst
Date: Thu, 27 May 2021 13:05:29 +0100	[thread overview]
Message-ID: <mpt7djk1iwm.fsf@arm.com> (raw)
In-Reply-To: <CAMqJFCoYEAztqESA5qoKaXh0B9sOHu=1PQZ+rS1Rq=zh6gS=gg@mail.gmail.com> (Joern Rennecke's message of "Sun, 16 May 2021 14:11:30 +0100")

Joern Rennecke <joern.rennecke@embecosm.com> writes:
> Bootstrapped on x86_64-pc-linux-gnu.
>
> 2020-12-10  Joern Rennecke  <joern.rennecke@embecosm.com>
>
>     Fix bug in the define_subst handling that made match_scratch unusable for
>     multi-alternative patterns.

OK, and sorry for the slow response.

The changelog won't pass, but I'll leave you to negotiate that with the
commit hook. :-)

Thanks,
Richard

>
> diff --git a/gcc/gensupport.c b/gcc/gensupport.c
> index e1ca06dbc1e..4022c661adb 100644
> --- a/gcc/gensupport.c
> +++ b/gcc/gensupport.c
> @@ -1291,6 +1291,9 @@ alter_constraints (rtx pattern, int n_dup, constraints_handler_t alter)
>      case MATCH_OPERAND:
>        XSTR (pattern, 2) = alter (XSTR (pattern, 2), n_dup);
>        break;
> +    case MATCH_SCRATCH:
> +      XSTR (pattern, 1) = alter (XSTR (pattern, 1), n_dup);
> +      break;
>  
>      default:
>        break;

      reply	other threads:[~2021-05-27 12:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 13:11 Joern Rennecke
2021-05-27 12:05 ` Richard Sandiford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mpt7djk1iwm.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joern.rennecke@embecosm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).