From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B79CB3857C65 for ; Thu, 17 Dec 2020 00:33:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B79CB3857C65 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69EFB31B; Wed, 16 Dec 2020 16:33:42 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB4D93F718; Wed, 16 Dec 2020 16:33:41 -0800 (PST) From: Richard Sandiford To: Jeff Law via Gcc-patches Mail-Followup-To: Jeff Law via Gcc-patches , Jeff Law , richard.sandiford@arm.com Subject: Re: [PATCH 22/23] Add rtl-ssa References: <79f3b9a3-423e-72f4-81b5-84dc65a9b6e9@redhat.com> Date: Thu, 17 Dec 2020 00:33:40 +0000 In-Reply-To: <79f3b9a3-423e-72f4-81b5-84dc65a9b6e9@redhat.com> (Jeff Law via Gcc-patches's message of "Tue, 15 Dec 2020 20:31:38 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 00:33:44 -0000 Jeff Law via Gcc-patches writes: > On 11/13/20 1:23 AM, Richard Sandiford via Gcc-patches wrote: >> This patch adds the RTL SSA infrastructure itself. The following >> fwprop.c patch will make use of it. >> >> gcc/ >> * configure.ac: Add rtl-ssa to the list of dependence directories. >> * configure: Regenerate. >> * Makefile.in (rtl-ssa-warn): New variable. >> (OBJS): Add the rtl-ssa object files. >> * emit-rtl.h (rtl_data::ssa): New field. >> * rtl-ssa.h: New file. >> * system.h: Include when INCLUDE_FUNCTIONAL is defined. >> * rtl-ssa: New directory. > So I know its late in stage3, but I think the risks here are relatively > minor as this would only be used in fwprop right now and it was posted > in advance of the deadline. > > My high level questions/concerns have been addressed and while I > strongly suspect we'll have to iterate on infrastructure, I think we can > do that on demand as passes start to use the infrastructure and we have > a clearer picture of what tweaks we need to make for the clients. Agreed. And I agree we'll need to iterate. What's there now certainly isn't complete. > Obviously we'll want to keep an eye on testresults, but again, the > potential for fallout here is relatively minor IMHO.=C2=A0 OK for the tru= nk. Thanks a lot for the reviews. Now pushed after retesting on aarch64-linux-gnu (with and without SVE), arm-linux-gnueabihf (as far as I could given the current state), x86_64-linux-gnu and powerpc64le-linux-gnu. Richard