From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id D0FDC3858289 for ; Mon, 8 Apr 2024 13:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0FDC3858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0FDC3858289 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712581402; cv=none; b=vCH4bYFKcj7zAP7HTAy1qu+Rtcw85VXDXjWVmjUyTzf1YXqhJdmbOvIpnvg++7R7ZlsHbmWrGLbvcXd6XKZnctOKYTldU+mhRVKfUTc1CFKWbZGVJEd+/C5+Kg6bKGFnHze5ju+m8nbI1huBo/dXIlZCHR5ugqm8RSsRaRA9zKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712581402; c=relaxed/simple; bh=Hvr/dOaccmLtWEoM2GQn7NY3bA8vAtYYPI65kwrRZhY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=EozJZ8MbjHn34TGn0yjpyjhA0vmKyX/iJCFNIiwaJyFUI3ARWSgMs/dzSvoR9D7DIUuzFBvm3Jks8rgI3yL8i1n1l38KrmpYsbQnZLdaq3mvwk62aarJxmBw3miDd9nYhdt1foggUiRAFU2zuS72yNG4cjH4OPTXxldD1EF7xhw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7BBADA7; Mon, 8 Apr 2024 06:03:50 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 078533F64C; Mon, 8 Apr 2024 06:03:19 -0700 (PDT) From: Richard Sandiford To: "Swinney\, Jonathan" Mail-Followup-To: "Swinney\, Jonathan" ,"gcc-patches\@gcc.gnu.org" , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" Subject: Re: [PATCH] aarch64: Fix vld1/st1_x4 intrinsic test References: Date: Mon, 08 Apr 2024 14:03:18 +0100 In-Reply-To: (Jonathan Swinney's message of "Mon, 8 Apr 2024 01:36:37 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-20.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Swinney, Jonathan" writes: > The test for this intrinsic was failing silently and so it failed to > report the bug reported in 114521. This patch modifes the test to > report the result. > > Bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114521 > > Signed-off-by: Jonathan Swinney > --- > .../gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Thanks, pushed to trunk. Richard > > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > index 89b289bb21d..17db262a31a 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > @@ -3,6 +3,7 @@ > /* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > +#include > #include > #include "arm-neon-ref.h" > > @@ -71,13 +72,16 @@ VARIANT (float64, 2, q_f64) > VARIANTS (TESTMETH) > > #define CHECKS(BASE, ELTS, SUFFIX) \ > - if (test_vld1##SUFFIX##_x4 () != 0) \ > - fprintf (stderr, "test_vld1##SUFFIX##_x4"); > + if (test_vld1##SUFFIX##_x4 () != 0) { \ > + fprintf (stderr, "test_vld1" #SUFFIX "_x4 failed\n"); \ > + failed = true; \ > + } > > int > main (int argc, char **argv) > { > + bool failed = false; > VARIANTS (CHECKS) > > - return 0; > + return (failed) ? 1 : 0; > }