From: Richard Sandiford <richard.sandiford@arm.com>
To: Richard Biener <rguenther@suse.de>
Cc: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>,
Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][RFC] tree-optimization/92335 - Improve sinking heuristics for vectorization
Date: Tue, 15 Aug 2023 09:58:16 +0100 [thread overview]
Message-ID: <mpt8racptqv.fsf@arm.com> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2308150711570.12935@jbgna.fhfr.qr> (Richard Biener's message of "Tue, 15 Aug 2023 07:36:39 +0000 (UTC)")
Richard Biener <rguenther@suse.de> writes:
> On Mon, 14 Aug 2023, Prathamesh Kulkarni wrote:
>> On Mon, 7 Aug 2023 at 13:19, Richard Biener <richard.guenther@gmail.com> wrote:
>> > It doesn't seem to make a difference for x86. That said, the "fix" is
>> > probably sticking the correct target on the dump-check, it seems
>> > that vect_fold_extract_last is no longer correct here.
>> Um sorry, I did go thru various checks in target-supports.exp, but not
>> sure which one will be appropriate for this case,
>> and am stuck here :/ Could you please suggest how to proceed ?
>
> Maybe Richard S. knows the magic thing to test, he originally
> implemented the direct conversion support. I suggest to implement
> such dg-checks if they are not present (I can't find them),
> possibly quite specific to the modes involved (like we have
> other checks with _qi_to_hi suffixes, for float modes maybe
> just _float).
Yeah, can't remember specific selectors for that feature. TBH I think
most (all?) of the tests were AArch64-specific.
Thanks,
Richard
next prev parent reply other threads:[~2023-08-15 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 7:05 Richard Biener
2023-07-31 15:33 ` Jeff Law
2023-08-02 8:46 ` Richard Biener
2023-08-03 11:42 ` Prathamesh Kulkarni
2023-08-03 12:14 ` Richard Biener
2023-08-03 12:16 ` Richard Biener
2023-08-03 12:18 ` Richard Biener
2023-08-07 0:04 ` Prathamesh Kulkarni
2023-08-07 7:48 ` Richard Biener
2023-08-14 14:58 ` Prathamesh Kulkarni
2023-08-15 7:36 ` Richard Biener
2023-08-15 8:58 ` Richard Sandiford [this message]
2023-08-17 17:10 ` Prathamesh Kulkarni
2023-08-18 9:29 ` Richard Biener
2023-08-18 11:41 ` Richard Biener
2023-08-19 15:48 ` Prathamesh Kulkarni
2023-08-21 6:57 ` Richard Biener
2023-08-21 11:32 ` Prathamesh Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpt8racptqv.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=prathamesh.kulkarni@linaro.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).