From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 892B53858D32 for ; Fri, 13 Jan 2023 10:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 892B53858D32 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.de Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EEA1FEC; Fri, 13 Jan 2023 02:04:18 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CFD23F67D; Fri, 13 Jan 2023 02:03:35 -0800 (PST) From: Richard Biener To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org,Richard Biener , richard.sandiford@arm.com Cc: Richard Biener Subject: [pushed] aarch64: Don't update EH info when folding [PR107209] Date: Fri, 13 Jan 2023 10:03:34 +0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-27.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The AArch64 folders tried to update EH info on the fly, bypassing the folder's attempts to remove dead EH edges later. This triggered an ICE when folding a potentially-trapping call to a constant. Thanks to Richard for the patch. Tested on aarch64-linux-gnu & pushed. gcc/ PR target/107209 * config/aarch64/aarch64.cc (aarch64_gimple_fold_builtin): Don't update EH info on the fly. gcc/testsuite/ * gcc.target/aarch64/pr107209.c: New test. Co-Authored-By: Richard Biener --- gcc/config/aarch64/aarch64.cc | 2 +- gcc/testsuite/gcc.target/aarch64/pr107209.c | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/aarch64/pr107209.c diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index c8335e7def7..80b71a7b612 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -15348,7 +15348,7 @@ aarch64_gimple_fold_builtin (gimple_stmt_iterator *gsi) if (!new_stmt) return false; - gsi_replace (gsi, new_stmt, true); + gsi_replace (gsi, new_stmt, false); return true; } diff --git a/gcc/testsuite/gcc.target/aarch64/pr107209.c b/gcc/testsuite/gcc.target/aarch64/pr107209.c new file mode 100644 index 00000000000..b86a6ea9036 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/pr107209.c @@ -0,0 +1,16 @@ +/* { dg-options "-O2 -fnon-call-exceptions -fno-tree-fre" } */ + +#include + +float64x1_t +foo (void) +{ + float64_t v1 = 3.14159265359; + float64_t v2 = 1.383894; + float64_t vec_1_data[] = {v1}; + float64_t vec_2_data[] = {v2}; + float64x1_t vec_1 = vld1_f64 (vec_1_data); + float64x1_t vec_2 = vld1_f64 (vec_2_data); + + return vmulx_f64 (vec_1, vec_2); +} -- 2.25.1