public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode
Date: Thu, 30 May 2019 10:14:00 -0000	[thread overview]
Message-ID: <mpt8suoz3el.fsf@arm.com> (raw)
In-Reply-To: <CAAgBjMn15JsPyvFYq8=BAxe7SqzvwExP0OSzvOeszDy1HkqtEQ@mail.gmail.com>	(Prathamesh Kulkarni's message of "Thu, 30 May 2019 14:59:40 +0530")

Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
> diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c
> new file mode 100644
> index 00000000000..cbfeff4a59c
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c
> @@ -0,0 +1,27 @@
> +/* { dg-do compile { target aarch64_asm_sve_ok } } */
> +/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 --save-temps" } */

Sorry for not noticing last time, but the combination of aarch64_asm_sve_ok
and --save-temps only makes sense for assemble tests, not compile tests.
So these should either be:

/* { dg-do assemble { target aarch64_asm_sve_ok } } */
/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256 --save-temps" } */

or:

/* { dg-do compile } */
/* { dg-options "-O2 -fno-schedule-insns -msve-vector-bits=256" } */

Might as well as go for the first I guess.  Same for the other
non-run tests.

OK with that change, thanks.

Richard

  reply	other threads:[~2019-05-30  9:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 10:27 Prathamesh Kulkarni
2019-05-29 12:40 ` Richard Sandiford
2019-05-30  9:37   ` Prathamesh Kulkarni
2019-05-30 10:14     ` Richard Sandiford [this message]
2019-05-30 14:52       ` Prathamesh Kulkarni
2019-05-30 16:01         ` Richard Sandiford
2019-06-03  7:26           ` Prathamesh Kulkarni
2019-06-03  9:23             ` Richard Sandiford
2019-06-03  9:52               ` Prathamesh Kulkarni
2019-06-03 10:55                 ` Richard Sandiford
2019-06-03 12:15                   ` Prathamesh Kulkarni
2019-06-06 11:10             ` Szabolcs Nagy
2019-06-06 11:24               ` Richard Sandiford
2019-06-07  9:46                 ` Prathamesh Kulkarni
2019-06-07 12:56                   ` Richard Sandiford
2019-06-07 16:29                     ` Prathamesh Kulkarni
2019-06-07 17:17                       ` Richard Sandiford
2019-06-08  8:32                         ` Prathamesh Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mpt8suoz3el.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=prathamesh.kulkarni@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).