From: Richard Sandiford <richard.sandiford@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH] libgcc: Add missing HWCAP entries to aarch64/cpuinfo.c
Date: Tue, 02 Apr 2024 13:46:39 +0100 [thread overview]
Message-ID: <mpta5mc0w5s.fsf@arm.com> (raw)
In-Reply-To: <PAWPR08MB898273C545B67C78EFC401E0833E2@PAWPR08MB8982.eurprd08.prod.outlook.com> (Wilco Dijkstra's message of "Tue, 2 Apr 2024 13:21:49 +0100")
Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> A few HWCAP entries are missing from aarch64/cpuinfo.c. This results in build errors
> on older machines.
>
> This counts a trivial build fix, but since it's late in stage 4 I'll let maintainers chip in.
> OK for commit?
>
> libgcc/
> * config/aarch64/cpuinfo.c: Add HWCAP_EVTSTRM, HWCAP_CRC32, HWCAP_CPUID,
> HWCAP_PACA and HWCAP_PACG.
OK, thanks.
Richard
> ---
>
> diff --git a/libgcc/config/aarch64/cpuinfo.c b/libgcc/config/aarch64/cpuinfo.c
> index 3c6fb8a575b423c2aff71a1a9f40812b154ee284..4b94fca869507145ec690c825f637abbc82a3493 100644
> --- a/libgcc/config/aarch64/cpuinfo.c
> +++ b/libgcc/config/aarch64/cpuinfo.c
> @@ -52,15 +52,15 @@ struct {
> #ifndef AT_HWCAP
> #define AT_HWCAP 16
> #endif
> -#ifndef HWCAP_CPUID
> -#define HWCAP_CPUID (1 << 11)
> -#endif
> #ifndef HWCAP_FP
> #define HWCAP_FP (1 << 0)
> #endif
> #ifndef HWCAP_ASIMD
> #define HWCAP_ASIMD (1 << 1)
> #endif
> +#ifndef HWCAP_EVTSTRM
> +#define HWCAP_EVTSTRM (1 << 2)
> +#endif
> #ifndef HWCAP_AES
> #define HWCAP_AES (1 << 3)
> #endif
> @@ -73,6 +73,9 @@ struct {
> #ifndef HWCAP_SHA2
> #define HWCAP_SHA2 (1 << 6)
> #endif
> +#ifndef HWCAP_CRC32
> +#define HWCAP_CRC32 (1 << 7)
> +#endif
> #ifndef HWCAP_ATOMICS
> #define HWCAP_ATOMICS (1 << 8)
> #endif
> @@ -82,6 +85,9 @@ struct {
> #ifndef HWCAP_ASIMDHP
> #define HWCAP_ASIMDHP (1 << 10)
> #endif
> +#ifndef HWCAP_CPUID
> +#define HWCAP_CPUID (1 << 11)
> +#endif
> #ifndef HWCAP_ASIMDRDM
> #define HWCAP_ASIMDRDM (1 << 12)
> #endif
> @@ -133,6 +139,12 @@ struct {
> #ifndef HWCAP_SB
> #define HWCAP_SB (1 << 29)
> #endif
> +#ifndef HWCAP_PACA
> +#define HWCAP_PACA (1 << 30)
> +#endif
> +#ifndef HWCAP_PACG
> +#define HWCAP_PACG (1UL << 31)
> +#endif
>
> #ifndef HWCAP2_DCPODP
> #define HWCAP2_DCPODP (1 << 0)
prev parent reply other threads:[~2024-04-02 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 12:21 Wilco Dijkstra
2024-04-02 12:46 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpta5mc0w5s.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).