From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 3AE87385840A for ; Tue, 2 Apr 2024 12:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AE87385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AE87385840A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712062003; cv=none; b=wjSgxysDWv1Jfrp2SvBbOH+n0fIpVL7+rWkGBs8Qr3guiOgp/m2mlr1xZKNAkpZ+/qO6IsgTVtsjVnfZt7K+g+hmtMI1wMvD9TT2/BgHNNjYuULHCfurgfSiiSlL/ufq/WV44CNBlZf9vOrxbOBrEBf3vcQoYgCxhAPB1+m9inM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712062003; c=relaxed/simple; bh=0LyAfFv10PY0dygx1wSLyzgcgFBoeJ0Dk2Jv7G6Sn0c=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=qdpsd+pPmd0iQd8FDIdXw4Xd4Eub9RbBztzLQK4orqi05uh2X1lPpNSfOCdVabyow0wEHFKIWjISKX29GRbjnls4/TuSKA+S/bPsHv35OWTNDHCrQcynZsJR6lkGrlIJ1icMfPCU5Z9+nHJJaOOQPAdGy6RhRlaPpT7QCGTrMuY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 582141007; Tue, 2 Apr 2024 05:47:13 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D29863F766; Tue, 2 Apr 2024 05:46:40 -0700 (PDT) From: Richard Sandiford To: Wilco Dijkstra Mail-Followup-To: Wilco Dijkstra ,GCC Patches , Kyrylo Tkachov , Richard Earnshaw , richard.sandiford@arm.com Cc: GCC Patches , Kyrylo Tkachov , Richard Earnshaw Subject: Re: [PATCH] libgcc: Add missing HWCAP entries to aarch64/cpuinfo.c References: Date: Tue, 02 Apr 2024 13:46:39 +0100 In-Reply-To: (Wilco Dijkstra's message of "Tue, 2 Apr 2024 13:21:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-20.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Wilco Dijkstra writes: > A few HWCAP entries are missing from aarch64/cpuinfo.c. This results in build errors > on older machines. > > This counts a trivial build fix, but since it's late in stage 4 I'll let maintainers chip in. > OK for commit? > > libgcc/ > * config/aarch64/cpuinfo.c: Add HWCAP_EVTSTRM, HWCAP_CRC32, HWCAP_CPUID, > HWCAP_PACA and HWCAP_PACG. OK, thanks. Richard > --- > > diff --git a/libgcc/config/aarch64/cpuinfo.c b/libgcc/config/aarch64/cpuinfo.c > index 3c6fb8a575b423c2aff71a1a9f40812b154ee284..4b94fca869507145ec690c825f637abbc82a3493 100644 > --- a/libgcc/config/aarch64/cpuinfo.c > +++ b/libgcc/config/aarch64/cpuinfo.c > @@ -52,15 +52,15 @@ struct { > #ifndef AT_HWCAP > #define AT_HWCAP 16 > #endif > -#ifndef HWCAP_CPUID > -#define HWCAP_CPUID (1 << 11) > -#endif > #ifndef HWCAP_FP > #define HWCAP_FP (1 << 0) > #endif > #ifndef HWCAP_ASIMD > #define HWCAP_ASIMD (1 << 1) > #endif > +#ifndef HWCAP_EVTSTRM > +#define HWCAP_EVTSTRM (1 << 2) > +#endif > #ifndef HWCAP_AES > #define HWCAP_AES (1 << 3) > #endif > @@ -73,6 +73,9 @@ struct { > #ifndef HWCAP_SHA2 > #define HWCAP_SHA2 (1 << 6) > #endif > +#ifndef HWCAP_CRC32 > +#define HWCAP_CRC32 (1 << 7) > +#endif > #ifndef HWCAP_ATOMICS > #define HWCAP_ATOMICS (1 << 8) > #endif > @@ -82,6 +85,9 @@ struct { > #ifndef HWCAP_ASIMDHP > #define HWCAP_ASIMDHP (1 << 10) > #endif > +#ifndef HWCAP_CPUID > +#define HWCAP_CPUID (1 << 11) > +#endif > #ifndef HWCAP_ASIMDRDM > #define HWCAP_ASIMDRDM (1 << 12) > #endif > @@ -133,6 +139,12 @@ struct { > #ifndef HWCAP_SB > #define HWCAP_SB (1 << 29) > #endif > +#ifndef HWCAP_PACA > +#define HWCAP_PACA (1 << 30) > +#endif > +#ifndef HWCAP_PACG > +#define HWCAP_PACG (1UL << 31) > +#endif > > #ifndef HWCAP2_DCPODP > #define HWCAP2_DCPODP (1 << 0)