From: Richard Sandiford <richard.sandiford@arm.com>
To: Andrew Pinski <quic_apinski@quicinc.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] aarch64: Use vec_perm_indices::new_shrunk_vector in aarch64_evpc_reencode
Date: Wed, 14 Feb 2024 21:27:29 +0000 [thread overview]
Message-ID: <mpta5o2spmm.fsf@arm.com> (raw)
In-Reply-To: <20240213032129.3744441-1-quic_apinski@quicinc.com> (Andrew Pinski's message of "Mon, 12 Feb 2024 19:21:29 -0800")
Andrew Pinski <quic_apinski@quicinc.com> writes:
> While working on PERM related stuff, I can across that aarch64_evpc_reencode
> was manually figuring out if we shrink the perm indices instead of
> using vec_perm_indices::new_shrunk_vector; shrunk was added after reencode
> was added.
>
> Built and tested for aarch64-linux-gnu with no regressions.
>
> gcc/ChangeLog:
>
> PR target/113822
> * config/aarch64/aarch64.cc (aarch64_evpc_reencode): Use
> vec_perm_indices::new_shrunk_vector instead of manually
> going through the indices.
Good spot! OK for stage 1, thanks.
Richard
>
> Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
> ---
> gcc/config/aarch64/aarch64.cc | 24 +++++-------------------
> 1 file changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> index 32eae49d4e9..f4ed8b86532 100644
> --- a/gcc/config/aarch64/aarch64.cc
> +++ b/gcc/config/aarch64/aarch64.cc
> @@ -25431,7 +25431,6 @@ static bool
> aarch64_evpc_reencode (struct expand_vec_perm_d *d)
> {
> expand_vec_perm_d newd;
> - unsigned HOST_WIDE_INT nelt;
>
> if (d->vec_flags != VEC_ADVSIMD)
> return false;
> @@ -25446,24 +25445,10 @@ aarch64_evpc_reencode (struct expand_vec_perm_d *d)
> if (new_mode == word_mode)
> return false;
>
> - /* to_constant is safe since this routine is specific to Advanced SIMD
> - vectors. */
> - nelt = d->perm.length ().to_constant ();
> -
> - vec_perm_builder newpermconst;
> - newpermconst.new_vector (nelt / 2, nelt / 2, 1);
> + vec_perm_indices newpermindices;
>
> - /* Convert the perm constant if we can. Require even, odd as the pairs. */
> - for (unsigned int i = 0; i < nelt; i += 2)
> - {
> - poly_int64 elt0 = d->perm[i];
> - poly_int64 elt1 = d->perm[i + 1];
> - poly_int64 newelt;
> - if (!multiple_p (elt0, 2, &newelt) || maybe_ne (elt0 + 1, elt1))
> - return false;
> - newpermconst.quick_push (newelt.to_constant ());
> - }
> - newpermconst.finalize ();
> + if (!newpermindices.new_shrunk_vector (d->perm, 2))
> + return false;
>
> newd.vmode = new_mode;
> newd.vec_flags = VEC_ADVSIMD;
> @@ -25475,7 +25460,8 @@ aarch64_evpc_reencode (struct expand_vec_perm_d *d)
> newd.testing_p = d->testing_p;
> newd.one_vector_p = d->one_vector_p;
>
> - newd.perm.new_vector (newpermconst, newd.one_vector_p ? 1 : 2, nelt / 2);
> + newd.perm.new_vector (newpermindices.encoding (), newd.one_vector_p ? 1 : 2,
> + newpermindices.nelts_per_input ());
> return aarch64_expand_vec_perm_const_1 (&newd);
> }
prev parent reply other threads:[~2024-02-14 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 3:21 Andrew Pinski
2024-02-14 21:27 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpta5o2spmm.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=quic_apinski@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).