From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 754423858D32 for ; Mon, 27 Feb 2023 12:16:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 754423858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B856C14; Mon, 27 Feb 2023 04:17:18 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.99.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E4C43F67D; Mon, 27 Feb 2023 04:16:34 -0800 (PST) From: Richard Sandiford To: Tejas Belagod Mail-Followup-To: Tejas Belagod ,, , richard.sandiford@arm.com Cc: , Subject: Re: [PATCH 1/2, GCC12] AArch64: Update transitive closures of aes, sha2 and sha3 extensions References: <20230216061351.25090-1-tejas.belagod@arm.com> Date: Mon, 27 Feb 2023 12:16:33 +0000 In-Reply-To: <20230216061351.25090-1-tejas.belagod@arm.com> (Tejas Belagod's message of "Thu, 16 Feb 2023 06:13:50 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-35.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tejas Belagod writes: > Transitive closures of architectural extensions have to be manually maintained > for AARCH64_OPT_EXTENSION list. Currently aes, sha2 and sha3 extensions add > AARCH64_FL_SIMD has their dependency - this does not automatically pull in the > transitive dependence of AARCH64_FL_FP from AARCH64_FL_SIMD's definition. As > described the transitive closure/dependence has to be maintained manually. > This patch adds AARCH64_FL_FP to each of these crypto extensions' dependence > set. Automatic transitive closure maintenance is fixed on trunk in commit > 11a113d501ff64fa4843e28d0a21b3f4e9d0d3de. > > gcc/ChangeLog: > > * config/aarch64/aarch64-option-extensions.def (aes, sha2, sha3): > Update AARCH64_OPT_EXTENSION definition of architectural dependence for > defintion of aes, sha2 and sha3 with AARCH64_FL_FP. OK, thanks. Richard > --- > gcc/config/aarch64/aarch64-option-extensions.def | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/config/aarch64/aarch64-option-extensions.def b/gcc/config/aarch64/aarch64-option-extensions.def > index b4d0ac8b600..88cefc20022 100644 > --- a/gcc/config/aarch64/aarch64-option-extensions.def > +++ b/gcc/config/aarch64/aarch64-option-extensions.def > @@ -118,19 +118,19 @@ AARCH64_OPT_EXTENSION("dotprod", AARCH64_FL_DOTPROD, AARCH64_FL_SIMD, 0, \ > > /* Enabling "aes" also enables "simd". > Disabling "aes" disables "aes" and "sve2-aes'. */ > -AARCH64_OPT_EXTENSION("aes", AARCH64_FL_AES, AARCH64_FL_SIMD, \ > - AARCH64_FL_SVE2_AES, false, "aes") > +AARCH64_OPT_EXTENSION("aes", AARCH64_FL_AES, AARCH64_FL_SIMD | \ > + AARCH64_FL_FP, AARCH64_FL_SVE2_AES, false, "aes") > > /* Enabling "sha2" also enables "simd". > Disabling "sha2" just disables "sha2". */ > -AARCH64_OPT_EXTENSION("sha2", AARCH64_FL_SHA2, AARCH64_FL_SIMD, 0, false, \ > - "sha1 sha2") > +AARCH64_OPT_EXTENSION("sha2", AARCH64_FL_SHA2, AARCH64_FL_SIMD | \ > + AARCH64_FL_FP, 0, false, "sha1 sha2") > > /* Enabling "sha3" enables "simd" and "sha2". > Disabling "sha3" disables "sha3" and "sve2-sha3". */ > AARCH64_OPT_EXTENSION("sha3", AARCH64_FL_SHA3, AARCH64_FL_SIMD | \ > - AARCH64_FL_SHA2, AARCH64_FL_SVE2_SHA3, false, \ > - "sha3 sha512") > + AARCH64_FL_SHA2 | AARCH64_FL_FP, AARCH64_FL_SVE2_SHA3, \ > + false, "sha3 sha512") > > /* Enabling "sm4" also enables "simd". > Disabling "sm4" disables "sm4" and "sve2-sm4". */