From: Richard Sandiford <richard.sandiford@arm.com>
To: Richard Biener <rguenther@suse.de>
Cc: "Andre Vieira \(lists\)" <andre.simoesdiasvieira@arm.com>,
"gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [vect] Re-analyze all modes for epilogues
Date: Tue, 07 Dec 2021 13:31:34 +0000 [thread overview]
Message-ID: <mpta6hcpmmh.fsf@arm.com> (raw)
In-Reply-To: <69658rp6-5prq-90p0-607-7s6p5o75462p@fhfr.qr> (Richard Biener's message of "Tue, 7 Dec 2021 12:48:10 +0100 (CET)")
Richard Biener <rguenther@suse.de> writes:
> On Tue, 7 Dec 2021, Andre Vieira (lists) wrote:
>
>> Hi,
>>
>> Rebased on top of the epilogue mode patch.
>>
>> OK for trunk?
>
> @@ -7242,7 +7315,8 @@ vectorizable_reduction (loop_vec_info loop_vinfo,
> participating. */
> if (ncopies > 1
> && (STMT_VINFO_RELEVANT (stmt_info) <= vect_used_only_live)
> - && reduc_chain_length == 1)
> + && reduc_chain_length == 1
> + && loop_vinfo->suggested_unroll_factor == 1)
> single_defuse_cycle = true;
>
> if (single_defuse_cycle || lane_reduc_code_p)
>
> It seems to me that 'ncopies' should include
> loop_vinfo->suggested_unroll_factor already so the check shouldn't be
> necessary.
Yeah, ncopies will be >1 for the unroll case. But the point is that
for unrolling, we want each unrolled loop to have its own reduction
accumulator, since reducing the aggregate loop-carried latency is one
of the main benefits of unrolling a reduction.
Thanks,
Richard
next prev parent reply other threads:[~2021-12-07 13:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 15:27 [PATCH 0/3][vect] Enable vector unrolling of main loop Andre Vieira (lists)
2021-09-17 15:31 ` [PATCH 1/3][vect] Add main vectorized loop unrolling Andre Vieira (lists)
2021-09-21 12:30 ` Richard Biener
2021-09-21 16:34 ` Andre Vieira (lists)
2021-09-22 6:14 ` Richard Biener
2021-09-30 8:52 ` [PATCH 1v2/3][vect] " Andre Vieira (lists)
2021-10-01 8:19 ` Richard Biener
2021-10-04 16:30 ` Richard Sandiford
2021-10-12 10:35 ` Andre Vieira (lists)
2021-10-15 8:48 ` Richard Biener
2021-10-20 13:29 ` Andre Vieira (lists)
2021-10-21 12:14 ` Richard Biener
2021-10-22 10:18 ` Richard Sandiford
2021-11-11 16:02 ` Andre Vieira (lists)
2021-11-12 13:12 ` Richard Biener
2021-11-22 11:41 ` Andre Vieira (lists)
2021-11-22 12:39 ` Richard Biener
2021-11-24 9:46 ` Andre Vieira (lists)
2021-11-24 11:00 ` Richard Biener
2021-11-25 10:40 ` Andre Vieira (lists)
2021-11-25 12:46 ` Richard Biener
2021-11-30 11:36 ` Andre Vieira (lists)
2021-11-30 13:56 ` Richard Biener
2021-12-07 11:27 ` [vect] Re-analyze all modes for epilogues Andre Vieira (lists)
2021-12-07 11:31 ` Andre Vieira (lists)
2021-12-07 11:48 ` Richard Biener
2021-12-07 13:31 ` Richard Sandiford [this message]
2021-12-07 13:33 ` Richard Biener
2021-12-07 11:45 ` Richard Biener
2021-12-07 15:17 ` Andre Vieira (lists)
2021-12-13 16:41 ` Andre Vieira (lists)
2021-12-14 11:39 ` Richard Sandiford
2021-12-17 16:33 ` Andre Vieira (lists)
2022-01-07 12:39 ` Richard Sandiford
2022-01-10 18:31 ` [PATCH 1v2/3][vect] Add main vectorized loop unrolling Andre Vieira (lists)
2022-01-11 7:14 ` Richard Biener
2021-10-22 10:12 ` Richard Sandiford
2021-09-17 15:32 ` [PATCH 2/3][vect] Consider outside costs earlier for epilogue loops Andre Vieira (lists)
2021-10-14 13:44 ` Andre Vieira (lists)
2021-10-22 15:33 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mpta6hcpmmh.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=andre.simoesdiasvieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).