From: Richard Sandiford <richard.sandiford@arm.com>
To: Evgeny Karpov <Evgeny.Karpov@microsoft.com>
Cc: "gcc-patches\@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Richard Earnshaw \(lists\)" <Richard.Earnshaw@arm.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
Radek Barton <radek.barton@microsoft.com>
Subject: Re: [PATCH v1 3/6] Rename functions for reuse in AArch64
Date: Wed, 22 May 2024 12:46:06 +0100 [thread overview]
Message-ID: <mptcypejcht.fsf@arm.com> (raw)
In-Reply-To: <PR3PR83MB0425B52DC6424B31ACBC9BC4F80E2@PR3PR83MB0425.EURPRD83.prod.outlook.com> (Evgeny Karpov's message of "Thu, 18 Apr 2024 21:45:57 +0000")
Evgeny Karpov <Evgeny.Karpov@microsoft.com> writes:
> This patch renames functions related to dllimport/dllexport
> and selectany functionality. These functions will be reused
> in the aarch64-w64-mingw32 target.
>
> gcc/ChangeLog:
>
> * config/i386/cygming.h (mingw_pe_record_stub):
> Rename functions in mingw folder which will be reused for
> aarch64.
> (TARGET_ASM_FILE_END): Update to new target-independent name.
> (SUBTARGET_ATTRIBUTE_TABLE): Likewise.
> (TARGET_VALID_DLLIMPORT_ATTRIBUTE_P): Likewise.
> (SUB_TARGET_RECORD_STUB): Likewise.
> * config/i386/i386-protos.h (ix86_handle_selectany_attribute): Likewise.
> (mingw_handle_selectany_attribute): Likewise.
> (i386_pe_valid_dllimport_attribute_p): Likewise.
> (mingw_pe_valid_dllimport_attribute_p): Likewise.
> (i386_pe_file_end): Likewise.
> (mingw_pe_file_end): Likewise.
> (i386_pe_record_stub): Likewise.
> (mingw_pe_record_stub): Likewise.
> * config/mingw/winnt.cc (ix86_handle_selectany_attribute): Likewise.
> (mingw_handle_selectany_attribute): Likewise.
> (i386_pe_valid_dllimport_attribute_p): Likewise.
> (mingw_pe_valid_dllimport_attribute_p): Likewise.
> (i386_pe_record_stub): Likewise.
> (mingw_pe_record_stub): Likewise.
> (i386_pe_file_end): Likewise.
> (mingw_pe_file_end): Likewise.
> * config/mingw/winnt.h (mingw_handle_selectany_attribute):
> Declate functionality that will be reused by multiple targets.
> (mingw_pe_file_end): Likewise.
> (mingw_pe_record_stub): Likewise.
> (mingw_pe_valid_dllimport_attribute_p): Likewise.
Ok, but...
> [...]
> diff --git a/gcc/config/mingw/winnt.cc b/gcc/config/mingw/winnt.cc
> index 9901576ade0..a0b5950be2e 100644
> --- a/gcc/config/mingw/winnt.cc
> +++ b/gcc/config/mingw/winnt.cc
> @@ -71,7 +71,7 @@ ix86_handle_shared_attribute (tree *node, tree name, tree, int,
> /* Handle a "selectany" attribute;
> arguments as in struct attribute_spec.handler. */
> tree
> -ix86_handle_selectany_attribute (tree *node, tree name, tree, int,
> +mingw_handle_selectany_attribute (tree *node, tree name, tree, int,
> bool *no_add_attrs)
please reindent the parameters for the new name length.
Thanks,
Richard
next prev parent reply other threads:[~2024-05-22 11:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 21:35 [PATCH v1 0/6] Add DLL import/export implementation to AArch64 Evgeny Karpov
2024-04-18 21:41 ` [PATCH v1 1/6] Move mingw_* declarations to the mingw folder Evgeny Karpov
2024-04-18 21:43 ` [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw Evgeny Karpov
2024-05-22 11:05 ` Richard Sandiford
2024-05-22 14:32 ` Evgeny Karpov
2024-05-23 8:35 ` Uros Bizjak
2024-05-23 8:41 ` Uros Bizjak
2024-05-23 17:53 ` Evgeny Karpov
2024-05-23 19:37 ` Uros Bizjak
2024-04-18 21:45 ` [PATCH v1 3/6] Rename functions for reuse in AArch64 Evgeny Karpov
2024-05-22 11:46 ` Richard Sandiford [this message]
2024-04-18 21:46 ` [PATCH v1 4/6] aarch64: Add selectany attribute handling Evgeny Karpov
2024-05-22 11:57 ` Richard Sandiford
2024-04-18 21:48 ` [PATCH v1 5/6] Adjust DLL import/export implementation for AArch64 Evgeny Karpov
2024-05-22 12:07 ` Richard Sandiford
2024-04-18 21:49 ` [PATCH v1 6/6] aarch64: Add DLL import/export to AArch64 target Evgeny Karpov
2024-06-04 20:10 ` [PATCH v1 0/6] Add DLL import/export implementation to AArch64 Evgeny Karpov
2024-06-05 6:01 ` Uros Bizjak
2024-06-05 23:41 ` Jonathan Yong
2024-06-06 9:23 ` Evgeny Karpov
2024-06-08 1:59 ` Jonathan Yong
2024-06-05 8:13 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptcypejcht.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=Evgeny.Karpov@microsoft.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=radek.barton@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).