From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 43B453858D26 for ; Wed, 22 May 2024 11:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43B453858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43B453858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716378370; cv=none; b=WtFjFVh5U8+kXkjt1Y4AWUUbjed9j8JH3F+G80Y5KTo2wMjYG8IdLm+Yk63L/zBLo9mGCoP+Y1Z/FGruAh9tdLWLxM73e6xFIFq0hZlIfLYkiEKbvDZSI9oR2hNDMUUJR8JNPemXm/xqoh/80/8GCOXcgkSv2OcvhC3+33AwC4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716378370; c=relaxed/simple; bh=c67MGgMMNLRWoscEieC0SyCEy+I4gBUwqszMkPN4Gcs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=iagVAG9o/D0Ri55zL/njGThrVBvz/6mYq/iE3RPuDq+b5J3lwLPit2UtGbYF3ul/c0YavePuzcAA+6IXQ7cMUorJMiwLk3xvJrap0vLoi849O90juB1h1+XVj7zv7/eBdZKhMrsyiHsq3Xv3mPsjTzMpEw0Vt8XWqbTHqflv8Pk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 20013339; Wed, 22 May 2024 04:46:32 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 46F503F641; Wed, 22 May 2024 04:46:07 -0700 (PDT) From: Richard Sandiford To: Evgeny Karpov Mail-Followup-To: Evgeny Karpov ,"gcc-patches\@gcc.gnu.org" , "Richard Earnshaw \(lists\)" , Maxim Kuvyrkov , Radek Barton , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" , "Richard Earnshaw \(lists\)" , Maxim Kuvyrkov , Radek Barton Subject: Re: [PATCH v1 3/6] Rename functions for reuse in AArch64 References: Date: Wed, 22 May 2024 12:46:06 +0100 In-Reply-To: (Evgeny Karpov's message of "Thu, 18 Apr 2024 21:45:57 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-20.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Evgeny Karpov writes: > This patch renames functions related to dllimport/dllexport > and selectany functionality. These functions will be reused > in the aarch64-w64-mingw32 target. > > gcc/ChangeLog: > > * config/i386/cygming.h (mingw_pe_record_stub): > Rename functions in mingw folder which will be reused for > aarch64. > (TARGET_ASM_FILE_END): Update to new target-independent name. > (SUBTARGET_ATTRIBUTE_TABLE): Likewise. > (TARGET_VALID_DLLIMPORT_ATTRIBUTE_P): Likewise. > (SUB_TARGET_RECORD_STUB): Likewise. > * config/i386/i386-protos.h (ix86_handle_selectany_attribute): Likewise. > (mingw_handle_selectany_attribute): Likewise. > (i386_pe_valid_dllimport_attribute_p): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise. > (i386_pe_file_end): Likewise. > (mingw_pe_file_end): Likewise. > (i386_pe_record_stub): Likewise. > (mingw_pe_record_stub): Likewise. > * config/mingw/winnt.cc (ix86_handle_selectany_attribute): Likewise. > (mingw_handle_selectany_attribute): Likewise. > (i386_pe_valid_dllimport_attribute_p): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise. > (i386_pe_record_stub): Likewise. > (mingw_pe_record_stub): Likewise. > (i386_pe_file_end): Likewise. > (mingw_pe_file_end): Likewise. > * config/mingw/winnt.h (mingw_handle_selectany_attribute): > Declate functionality that will be reused by multiple targets. > (mingw_pe_file_end): Likewise. > (mingw_pe_record_stub): Likewise. > (mingw_pe_valid_dllimport_attribute_p): Likewise. Ok, but... > [...] > diff --git a/gcc/config/mingw/winnt.cc b/gcc/config/mingw/winnt.cc > index 9901576ade0..a0b5950be2e 100644 > --- a/gcc/config/mingw/winnt.cc > +++ b/gcc/config/mingw/winnt.cc > @@ -71,7 +71,7 @@ ix86_handle_shared_attribute (tree *node, tree name, tree, int, > /* Handle a "selectany" attribute; > arguments as in struct attribute_spec.handler. */ > tree > -ix86_handle_selectany_attribute (tree *node, tree name, tree, int, > +mingw_handle_selectany_attribute (tree *node, tree name, tree, int, > bool *no_add_attrs) please reindent the parameters for the new name length. Thanks, Richard