From: Richard Sandiford <richard.sandiford@arm.com>
To: Alex Coplan <alex.coplan@arm.com>
Cc: gcc-patches@gcc.gnu.org, Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: [PATCH 03/11] aarch64, testsuite: Fix up auto-init-padding tests
Date: Tue, 21 Nov 2023 12:04:54 +0000 [thread overview]
Message-ID: <mptcyw3jord.fsf@arm.com> (raw)
In-Reply-To: <ZVZaXJY/K04w2ojw@arm.com> (Alex Coplan's message of "Thu, 16 Nov 2023 18:07:24 +0000")
Alex Coplan <alex.coplan@arm.com> writes:
> The tests currently depending on memcpy lowering forming stps at -O0,
> but we no longer want to form stps during memcpy lowering, but instead
> in the load/store pair fusion pass.
>
> This patch therefore tweaks affected tests to enable optimizations
> (-O1), and adjusts the tests to avoid parts of the structures being
> optimized away where necessary.
>
> OK for trunk?
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/auto-init-padding-1.c: Add -O to options,
> adjust test to work with optimizations enabled.
> * gcc.target/aarch64/auto-init-padding-2.c: Add -O to options.
> * gcc.target/aarch64/auto-init-padding-3.c: Add -O to options,
> adjust test to work with optimizations enabled.
> * gcc.target/aarch64/auto-init-padding-4.c: Likewise.
> * gcc.target/aarch64/auto-init-padding-9.c: Likewise.
OK, thanks.
Richard
> ---
> gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c | 8 +++++---
> gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c | 2 +-
> gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c | 7 ++++---
> gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c | 4 ++--
> gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c | 7 ++++---
> 5 files changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c
> index c747ebdcdf7..7027454dc74 100644
> --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c
> +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c
> @@ -1,17 +1,19 @@
> /* Verify zero initialization for structure type automatic variables with
> padding. */
> /* { dg-do compile } */
> -/* { dg-options "-ftrivial-auto-var-init=zero" } */
> +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */
>
> struct test_aligned {
> int internal1;
> long long internal2;
> } __attribute__ ((aligned(64)));
>
> -int foo ()
> +void bar (struct test_aligned *);
> +
> +void foo ()
> {
> struct test_aligned var;
> - return var.internal1;
> + bar(&var);
> }
>
> /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 2 } } */
> diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c
> index 6e280904da1..d3b6591c9b0 100644
> --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c
> @@ -1,7 +1,7 @@
> /* Verify pattern initialization for structure type automatic variables with
> padding. */
> /* { dg-do compile } */
> -/* { dg-options "-ftrivial-auto-var-init=pattern" } */
> +/* { dg-options "-O -ftrivial-auto-var-init=pattern" } */
>
> struct test_aligned {
> int internal1;
> diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c
> index 9ddea58b468..aad4bb8944f 100644
> --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c
> +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c
> @@ -1,7 +1,7 @@
> /* Verify zero initialization for nested structure type automatic variables with
> padding. */
> /* { dg-do compile } */
> -/* { dg-options "-ftrivial-auto-var-init=zero" } */
> +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */
>
> struct test_aligned {
> unsigned internal1;
> @@ -16,11 +16,12 @@ struct test_big_hole {
> struct test_aligned four;
> } __attribute__ ((aligned(64)));
>
> +void bar (struct test_big_hole *);
>
> -int foo ()
> +void foo ()
> {
> struct test_big_hole var;
> - return var.four.internal1;
> + bar (&var);
> }
>
> /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 4 } } */
> diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c
> index 75bba82ed34..efd310f054d 100644
> --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c
> +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c
> @@ -1,7 +1,7 @@
> /* Verify pattern initialization for nested structure type automatic variables with
> padding. */
> /* { dg-do compile } */
> -/* { dg-options "-ftrivial-auto-var-init=pattern" } */
> +/* { dg-options "-O -ftrivial-auto-var-init=pattern" } */
>
> struct test_aligned {
> unsigned internal1;
> @@ -23,4 +23,4 @@ int foo ()
> return var.four.internal1;
> }
>
> -/* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 5 } } */
> +/* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 4 } } */
> diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c
> index 0f1930f813e..64ed8f11fe6 100644
> --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c
> +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c
> @@ -1,7 +1,7 @@
> /* Verify zero initialization for array type with structure element with
> padding. */
> /* { dg-do compile } */
> -/* { dg-options "-ftrivial-auto-var-init=zero" } */
> +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */
>
> struct test_trailing_hole {
> int one;
> @@ -11,11 +11,12 @@ struct test_trailing_hole {
> /* "sizeof(unsigned long) - 1" byte padding hole here. */
> };
>
> +void bar (void *);
>
> -int foo ()
> +void foo ()
> {
> struct test_trailing_hole var[10];
> - return var[2].four;
> + bar (var);
> }
>
> /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 5 } } */
prev parent reply other threads:[~2023-11-21 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 18:07 Alex Coplan
2023-11-21 12:04 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptcyw3jord.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=alex.coplan@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).