From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 93BC23858D39 for ; Tue, 21 Nov 2023 12:04:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93BC23858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93BC23858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700568298; cv=none; b=kIureu82Q2UZ0dsSgXBt+27vL40/YS3Ypr5PvFopc0S9U6ItWtzc/9nGjBdbvbRA5YNGUQc3n43A7JYLOWDetc2dye2xAtV6zW8yNwpYdZoaguMmRiflML3ig1h9ushVpp7Opz1SXrf/8ZmpFdCwAxP1Yk+Tmx4kRzQeaUQbHeM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700568298; c=relaxed/simple; bh=ni9rtLpw7Wcn8oeh0i8wQyuPvKzAIEAI8TYW1JYdVw4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=HUJxHSBBACD5+xD0o0MsLqtb+FBEbDKG0BxTVa+WOYMBfbOHw9N7sufUECV4ORP5Grb5t75txUjfbgaU6uqXpxHUOKa/voHdk2ibqbTZvsbkOdXUo4XMpXfNnFcD8IYajdy607M+hMOINXTcqvPQ0d1C+82HSpRzjKZg8hguOE0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11746FEC; Tue, 21 Nov 2023 04:05:43 -0800 (PST) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C3ECE3F7A6; Tue, 21 Nov 2023 04:04:55 -0800 (PST) From: Richard Sandiford To: Alex Coplan Mail-Followup-To: Alex Coplan ,gcc-patches@gcc.gnu.org, Kyrylo Tkachov , richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org, Kyrylo Tkachov Subject: Re: [PATCH 03/11] aarch64, testsuite: Fix up auto-init-padding tests References: Date: Tue, 21 Nov 2023 12:04:54 +0000 In-Reply-To: (Alex Coplan's message of "Thu, 16 Nov 2023 18:07:24 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-22.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Alex Coplan writes: > The tests currently depending on memcpy lowering forming stps at -O0, > but we no longer want to form stps during memcpy lowering, but instead > in the load/store pair fusion pass. > > This patch therefore tweaks affected tests to enable optimizations > (-O1), and adjusts the tests to avoid parts of the structures being > optimized away where necessary. > > OK for trunk? > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/auto-init-padding-1.c: Add -O to options, > adjust test to work with optimizations enabled. > * gcc.target/aarch64/auto-init-padding-2.c: Add -O to options. > * gcc.target/aarch64/auto-init-padding-3.c: Add -O to options, > adjust test to work with optimizations enabled. > * gcc.target/aarch64/auto-init-padding-4.c: Likewise. > * gcc.target/aarch64/auto-init-padding-9.c: Likewise. OK, thanks. Richard > --- > gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c | 8 +++++--- > gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c | 2 +- > gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c | 7 ++++--- > gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c | 4 ++-- > gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c | 7 ++++--- > 5 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c > index c747ebdcdf7..7027454dc74 100644 > --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c > +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-1.c > @@ -1,17 +1,19 @@ > /* Verify zero initialization for structure type automatic variables with > padding. */ > /* { dg-do compile } */ > -/* { dg-options "-ftrivial-auto-var-init=zero" } */ > +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */ > > struct test_aligned { > int internal1; > long long internal2; > } __attribute__ ((aligned(64))); > > -int foo () > +void bar (struct test_aligned *); > + > +void foo () > { > struct test_aligned var; > - return var.internal1; > + bar(&var); > } > > /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 2 } } */ > diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c > index 6e280904da1..d3b6591c9b0 100644 > --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c > +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-2.c > @@ -1,7 +1,7 @@ > /* Verify pattern initialization for structure type automatic variables with > padding. */ > /* { dg-do compile } */ > -/* { dg-options "-ftrivial-auto-var-init=pattern" } */ > +/* { dg-options "-O -ftrivial-auto-var-init=pattern" } */ > > struct test_aligned { > int internal1; > diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c > index 9ddea58b468..aad4bb8944f 100644 > --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c > +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-3.c > @@ -1,7 +1,7 @@ > /* Verify zero initialization for nested structure type automatic variables with > padding. */ > /* { dg-do compile } */ > -/* { dg-options "-ftrivial-auto-var-init=zero" } */ > +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */ > > struct test_aligned { > unsigned internal1; > @@ -16,11 +16,12 @@ struct test_big_hole { > struct test_aligned four; > } __attribute__ ((aligned(64))); > > +void bar (struct test_big_hole *); > > -int foo () > +void foo () > { > struct test_big_hole var; > - return var.four.internal1; > + bar (&var); > } > > /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 4 } } */ > diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c > index 75bba82ed34..efd310f054d 100644 > --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c > +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-4.c > @@ -1,7 +1,7 @@ > /* Verify pattern initialization for nested structure type automatic variables with > padding. */ > /* { dg-do compile } */ > -/* { dg-options "-ftrivial-auto-var-init=pattern" } */ > +/* { dg-options "-O -ftrivial-auto-var-init=pattern" } */ > > struct test_aligned { > unsigned internal1; > @@ -23,4 +23,4 @@ int foo () > return var.four.internal1; > } > > -/* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 5 } } */ > +/* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 4 } } */ > diff --git a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c > index 0f1930f813e..64ed8f11fe6 100644 > --- a/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c > +++ b/gcc/testsuite/gcc.target/aarch64/auto-init-padding-9.c > @@ -1,7 +1,7 @@ > /* Verify zero initialization for array type with structure element with > padding. */ > /* { dg-do compile } */ > -/* { dg-options "-ftrivial-auto-var-init=zero" } */ > +/* { dg-options "-O -ftrivial-auto-var-init=zero" } */ > > struct test_trailing_hole { > int one; > @@ -11,11 +11,12 @@ struct test_trailing_hole { > /* "sizeof(unsigned long) - 1" byte padding hole here. */ > }; > > +void bar (void *); > > -int foo () > +void foo () > { > struct test_trailing_hole var[10]; > - return var[2].four; > + bar (var); > } > > /* { dg-final { scan-assembler-times {stp\tq[0-9]+, q[0-9]+,} 5 } } */