public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: juzhe.zhong@rivai.ai,  gcc-patches@gcc.gnu.org,  rguenther@suse.de
Subject: Re: [PATCH V6] VECT: Apply LEN_MASK_{LOAD,STORE} into vectorizer
Date: Fri, 23 Jun 2023 09:03:45 +0100	[thread overview]
Message-ID: <mptcz1m7ggu.fsf@arm.com> (raw)
In-Reply-To: <1BCB095A-85C7-4B27-B87B-368279BBEC8D@gmail.com> (Bernhard Reutner-Fischer's message of "Fri, 23 Jun 2023 09:55:43 +0200")

Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
> On 23 June 2023 01:51:12 CEST, juzhe.zhong@rivai.ai wrote:
>>From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> I am sorry but I somehow overlooked a trivial spot in V5.
> Nit which does not warrant an immediate next version, but please consider it before pushing iff approved:
>
>>+	      if (final_len)
>>+		{
>>+		  signed char biasval
>>+		    = LOOP_VINFO_PARTIAL_LOAD_STORE_BIAS (loop_vinfo);
>>+
>>+		  bias = build_int_cst (intQI_type_node, biasval);
>>+		}
>>+
>>+	      /* Arguments are ready.  Create the new vector stmt.  */
>>+	      if (final_len)
>>+		{
>
> Fuse the block below into the one above as the condition seems to be identical?

Yeah, true, but I think the idea is that the code above “Arguments are
ready” is calculating argument values, and the code after it is creating
code.  These are two separate steps, and the fact that the two final_len
blocks end up being consecutive is something of a coincidence.

So personally I think we should keep the structure in the patch.

Thanks,
Richard

  reply	other threads:[~2023-06-23  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 23:51 juzhe.zhong
2023-06-23  7:55 ` Bernhard Reutner-Fischer
2023-06-23  8:03   ` Richard Sandiford [this message]
2023-06-23  8:37     ` 钟居哲
2023-06-23  9:38     ` Bernhard Reutner-Fischer
2023-06-24  0:53       ` Li, Pan2
2023-06-23  8:08 ` Richard Sandiford
2023-06-23  8:10   ` 钟居哲

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mptcz1m7ggu.fsf@arm.com \
    --to=richard.sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=rep.dot.nop@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).