From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZsWn=CL=arm.com=richard.sandiford@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id C06D83858D37
	for <gcc-patches@gcc.gnu.org>; Fri, 23 Jun 2023 08:03:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C06D83858D37
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D9A7C14;
	Fri, 23 Jun 2023 01:04:31 -0700 (PDT)
Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 979613F64C;
	Fri, 23 Jun 2023 01:03:46 -0700 (PDT)
From: Richard Sandiford <richard.sandiford@arm.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Mail-Followup-To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,juzhe.zhong@rivai.ai,  gcc-patches@gcc.gnu.org,  rguenther@suse.de, richard.sandiford@arm.com
Cc: juzhe.zhong@rivai.ai,  gcc-patches@gcc.gnu.org,  rguenther@suse.de
Subject: Re: [PATCH V6] VECT: Apply LEN_MASK_{LOAD,STORE} into vectorizer
References: <20230622235112.9407-1-juzhe.zhong@rivai.ai>
	<1BCB095A-85C7-4B27-B87B-368279BBEC8D@gmail.com>
Date: Fri, 23 Jun 2023 09:03:45 +0100
In-Reply-To: <1BCB095A-85C7-4B27-B87B-368279BBEC8D@gmail.com> (Bernhard
	Reutner-Fischer's message of "Fri, 23 Jun 2023 09:55:43 +0200")
Message-ID: <mptcz1m7ggu.fsf@arm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-21.4 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
> On 23 June 2023 01:51:12 CEST, juzhe.zhong@rivai.ai wrote:
>>From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> I am sorry but I somehow overlooked a trivial spot in V5.
> Nit which does not warrant an immediate next version, but please consider=
 it before pushing iff approved:
>
>>+	      if (final_len)
>>+		{
>>+		  signed char biasval
>>+		    =3D LOOP_VINFO_PARTIAL_LOAD_STORE_BIAS (loop_vinfo);
>>+
>>+		  bias =3D build_int_cst (intQI_type_node, biasval);
>>+		}
>>+
>>+	      /* Arguments are ready.  Create the new vector stmt.  */
>>+	      if (final_len)
>>+		{
>
> Fuse the block below into the one above as the condition seems to be iden=
tical?

Yeah, true, but I think the idea is that the code above =E2=80=9CArguments =
are
ready=E2=80=9D is calculating argument values, and the code after it is cre=
ating
code.  These are two separate steps, and the fact that the two final_len
blocks end up being consecutive is something of a coincidence.

So personally I think we should keep the structure in the patch.

Thanks,
Richard