From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id BC6F33851C39 for ; Mon, 20 Jul 2020 17:56:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BC6F33851C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=richard.sandiford@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7997E106F; Mon, 20 Jul 2020 10:56:41 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.98.126]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 069F83F66F; Mon, 20 Jul 2020 10:56:40 -0700 (PDT) From: Richard Sandiford To: Dimitar Dimitrov Mail-Followup-To: Dimitar Dimitrov , gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/4] testsuite: Relax pattern to include "packed" targets References: <20200720163106.27849-1-dimitar@dinux.eu> <20200720163106.27849-4-dimitar@dinux.eu> Date: Mon, 20 Jul 2020 18:56:39 +0100 In-Reply-To: <20200720163106.27849-4-dimitar@dinux.eu> (Dimitar Dimitrov's message of "Mon, 20 Jul 2020 19:31:05 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 17:56:42 -0000 Dimitar Dimitrov writes: > The actual warning message depends on the default alignment of the > target. With this update the test correctly passes on AVR and PRU > targets. > > gcc/testsuite/ChangeLog: > > * gcc.dg/pr53037-1.c: Relax warning pattern. > > Signed-off-by: Dimitar Dimitrov > --- > gcc/testsuite/gcc.dg/pr53037-1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.dg/pr53037-1.c b/gcc/testsuite/gcc.dg/pr53= 037-1.c > index 3ea5ae6a34e..b4e9049c746 100644 > --- a/gcc/testsuite/gcc.dg/pr53037-1.c > +++ b/gcc/testsuite/gcc.dg/pr53037-1.c > @@ -40,7 +40,7 @@ struct foo5 > { > int i1; > int x __attribute__((warn_if_not_aligned(16))); /* { dg-warning "'x' o= ffset 4 in 'struct foo5' isn't aligned to 16" } */ > -}; /* { dg-warning "alignment 4 of 'struct foo5' is less than 16" } */ > +}; /* { dg-warning "alignment .* of 'struct foo5' is less than 16" } */ >=20=20 > struct foo6 > { > @@ -73,7 +73,7 @@ union bar3 > { > int i1; > int x __attribute__((warn_if_not_aligned(16)));=20 > -}; /* { dg-warning "alignment 4 of 'union bar3' is less than 16" } */ > +}; /* { dg-warning "alignment .* of 'union bar3' is less than 16" } */ Better to use [0-9]+, and change the quoting to {=E2=80=A6} rather than "= =E2=80=A6" so that there's no need to add backslashes for the [ and ]. OK with that change, thanks. Richard