From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 47CC43945C34 for ; Wed, 10 Apr 2024 18:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47CC43945C34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47CC43945C34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712774431; cv=none; b=MVNwpOq6JPRyKfxzbs2j7NyBtw9b4cXmyp9yszQxv33tJDi8xGs2JiNtt+f2OdEUpSSwA15kPpVGnyDaagBK0U0MFnR10kK77f57svl9e37K/W0CzE9nyYMk32RljMdGYCHGhKeVH0F2F1ypEOHGbGXaa5FvaKYIV0RPW5fQ3mA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712774431; c=relaxed/simple; bh=BAgJVLEgs/WTADT6PmD+zjPQlmgB3EmoaXT7cVKGVHo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=pAkfdFk9NvgG8QlZwcbn8yqsfVEkwDzdVe+o1HgYnjepBjxanXTDCEzFo3S5Cg/7fL7c8cW0bY0wLhSIylvM6h9bw/qVoxuA3m78dnl00Pfb2h92VgOrtoZ7OhHBpvDkpQWv3aQJQKIrrr7XX+8NsxXL7qFs9wfPGpmQTwFXYIg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AF25139F; Wed, 10 Apr 2024 11:40:50 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C95573F6C4; Wed, 10 Apr 2024 11:40:19 -0700 (PDT) From: Richard Sandiford To: Evgeny Karpov Mail-Followup-To: Evgeny Karpov ,"gcc-patches\@gcc.gnu.org" , "Richard Earnshaw \(lists\)" , "Andrew Pinski \(QUIC\)" , Maxim Kuvyrkov , Radek Barton , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" , "Richard Earnshaw \(lists\)" , "Andrew Pinski \(QUIC\)" , Maxim Kuvyrkov , Radek Barton Subject: Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target References: Date: Wed, 10 Apr 2024 19:40:18 +0100 In-Reply-To: (Evgeny Karpov's message of "Mon, 4 Mar 2024 17:24:10 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Evgeny Karpov writes: > Hello, > > v2 is ready for the review! > Based on the v1 review: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/thread.html#646203 > > Testing for the x86_64-w64-mingw32 target is in progress to avoid > regression due to refactoring. Thanks for the updates and sorry again for the slow review. I've replied to some of the patches in the series but otherwise it looks good to me. If you agree with the suggested changes then the series is OK for stage 1, assuming no objections from those with an interest in the x86 cygwin/mingw port. Richard > Regards, > Evgeny > > > Changes from v1 to v2: > Adjust the target name to aarch64-*-mingw* to exclude the big-endian > target from support. > Exclude 64-bit ISA. > Rename enum calling_abi to aarch64_calling_abi. > Move AArch64 MS ABI definitions FIXED_REGISTERS, > CALL_REALLY_USED_REGISTERS, and STATIC_CHAIN_REGNUM from aarch64.h > to aarch64-abi-ms.h. > Rename TARGET_ARM64_MS_ABI to TARGET_AARCH64_MS_ABI. > Exclude TARGET_64BIT from the aarch64 target. > Exclude HAVE_GAS_WEAK. > Set HAVE_GAS_ALIGNED_COMM to 1 by default. > Use a reference from "x86 Windows Options" to > "Cygwin and MinGW Options". > Update commit descriptions to follow standard style. > Rebase from 4th March 2024.