From: Richard Sandiford <richard.sandiford@arm.com>
To: Florian Weimer via Gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] libgcc: Move cfa_how into potential padding in struct frame_state_reg_info
Date: Fri, 14 Oct 2022 19:00:04 +0100 [thread overview]
Message-ID: <mptedvab80r.fsf@arm.com> (raw)
In-Reply-To: <874jw6mk1s.fsf@oldenburg.str.redhat.com> (Florian Weimer via Gcc-patches's message of "Fri, 14 Oct 2022 18:44:47 +0200")
Florian Weimer via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> On many architectures, there is a padding gap after the how array
> member, and cfa_how can be moved there. This reduces the size of the
> struct and the amount of memory that uw_frame_state_for has to clear.
>
> There is no measurable performance benefit from this on x86-64 (even
> though the memset goes from 120 to 112 bytes), but it seems to be a
> good idea to do anyway.
>
> libgcc/
>
> * unwind-dw2.h (struct frame_state_reg_info): Move cfa_how member
> and reduce its size.
OK, thanks.
Richard
>
> ---
> libgcc/unwind-dw2.h | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/libgcc/unwind-dw2.h b/libgcc/unwind-dw2.h
> index af34e000f07..a0834b18277 100644
> --- a/libgcc/unwind-dw2.h
> +++ b/libgcc/unwind-dw2.h
> @@ -50,6 +50,12 @@ typedef struct
> } reg[__LIBGCC_DWARF_FRAME_REGISTERS__+1];
> unsigned char how[__LIBGCC_DWARF_FRAME_REGISTERS__+1];
>
> + enum {
> + CFA_UNSET,
> + CFA_REG_OFFSET,
> + CFA_EXP
> + } cfa_how : 8;
> +
> /* Used to implement DW_CFA_remember_state. */
> struct frame_state_reg_info *prev;
>
> @@ -58,11 +64,6 @@ typedef struct
> _Unwind_Sword cfa_offset;
> _Unwind_Word cfa_reg;
> const unsigned char *cfa_exp;
> - enum {
> - CFA_UNSET,
> - CFA_REG_OFFSET,
> - CFA_EXP
> - } cfa_how;
> } regs;
>
> /* The PC described by the current frame state. */
>
> base-commit: 3dfeda095bd43c011fdc3834b9cec39bb9a73a1f
prev parent reply other threads:[~2022-10-14 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 16:44 Florian Weimer
2022-10-14 18:00 ` Richard Sandiford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mptedvab80r.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).